Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Nov 18, 2024

  • Current list-form does not support 100% of nft collection (they are either not indexed by the services that we are using, or they're customized in a way that can't be queried properly onchain)
  • This PR allows people to call the listing form, from inside the NFT page directly
  • This is also to unblock a customer

DASH-399

@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 6:41am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 18, 2024 6:41am
thirdweb_playground ⬜️ Skipped (Inspect) Nov 18, 2024 6:41am
wallet-ui ⬜️ Skipped (Inspect) Nov 18, 2024 6:41am

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: bccad06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 18, 2024 06:31 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 18, 2024 06:31 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 18, 2024 06:31 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 18, 2024
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (a00233d) to head (bccad06).
Report is 41 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5442   +/-   ##
=======================================
  Coverage   45.53%   45.53%           
=======================================
  Files        1070     1070           
  Lines       55690    55690           
  Branches     4033     4033           
=======================================
  Hits        25356    25356           
  Misses      29647    29647           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a00233d
packages 40.63% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@kien-ngo kien-ngo marked this pull request as ready for review November 18, 2024 06:33
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.88 KB (0%) 898 ms (0%) 3.2 s (+48.14% 🔺) 4.1 s
thirdweb (cjs) 105.07 KB (0%) 2.2 s (0%) 5.7 s (+13.05% 🔺) 7.8 s
thirdweb (minimal + tree-shaking) 5.72 KB (0%) 115 ms (0%) 374 ms (+218.32% 🔺) 488 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 151 ms (+252.85% 🔺) 161 ms
thirdweb/react (minimal + tree-shaking) 18.79 KB (0%) 376 ms (0%) 437 ms (-47.08% 🔽) 813 ms

Copy link
Member

@MananTank MananTank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modify the Direct Listing UI instead to always show both the "Select NFTs" UI and manual form entry in two tabs so its always possible to enter the NFT details manually

If the chain is not support for querying owned nfts - don't show 2 tabs - directly show the manual form entry as we do currently

@gregfromstl gregfromstl changed the title [Dashboard] List NFT to marketplace directly from token-page [Dashboard] Feature: List NFT to marketplace directly from token-page Nov 18, 2024
@kien-ngo kien-ngo closed this Nov 22, 2024
@kien-ngo kien-ngo deleted the kien/list-nft-from-token-page branch January 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants