Skip to content

Conversation

@ElasticBottle
Copy link
Contributor

@ElasticBottle ElasticBottle commented Nov 18, 2024

https://linear.app/thirdweb/issue/CNCT-2314/consolidate-documentation-for-in-app-wallets-and-ecosystem


PR-Codex overview

This PR focuses on the restructuring and enhancement of the thirdweb wallet documentation, including the removal of outdated files, the addition of new features, and the reorganization of content to improve clarity and accessibility for users.

Detailed summary

  • Deleted multiple outdated .mdx files related to sign-in and ecosystems.
  • Introduced new AuthList component for displaying authentication options.
  • Updated wallet security documentation to include enclave security details.
  • Improved organization of wallet-related guides and resources.
  • Added new content on guest mode, linking identities, and pregenerating wallets.
  • Enhanced the sidebar for better navigation within wallet documentation.
  • Revised existing pages to reflect new wallet features and configurations.

The following files were skipped due to too many changes: apps/portal/src/app/connect/sidebar.tsx, apps/portal/src/app/connect/wallet/faq/page.mdx, apps/portal/src/app/connect/wallet/user-management/get-user-profiles/page.mdx, apps/portal/redirects.mjs, apps/portal/src/app/connect/wallet/security/assets/ecosystem-scoped.svg

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 18, 2024

@vercel
Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:42pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:42pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:42pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 10:42pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024

⚠️ No Changeset found

Latest commit: 0998fc7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 18, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.9 KB (0%) 899 ms (0%) 646 ms (+31.75% 🔺) 1.6 s
thirdweb (cjs) 105.02 KB (0%) 2.2 s (0%) 1.2 s (+16.97% 🔺) 3.3 s
thirdweb (minimal + tree-shaking) 5.61 KB (0%) 113 ms (0%) 119 ms (+173.14% 🔺) 231 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 44 ms (+265.65% 🔺) 54 ms
thirdweb/react (minimal + tree-shaking) 18.41 KB (0%) 369 ms (0%) 213 ms (+90.3% 🔺) 581 ms

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.82%. Comparing base (3df0541) to head (0998fc7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5443      +/-   ##
==========================================
+ Coverage   45.53%   45.82%   +0.28%     
==========================================
  Files        1070     1069       -1     
  Lines       55716    55357     -359     
  Branches     4033     4032       -1     
==========================================
- Hits        25372    25366       -6     
+ Misses      29657    29304     -353     
  Partials      687      687              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 3df0541
packages 40.96% <ø> (+0.31%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...kages/thirdweb/src/wallets/in-app/web/ecosystem.ts 70.37% <ø> (ø)
packages/thirdweb/src/wallets/in-app/web/in-app.ts 60.00% <ø> (ø)
.../thirdweb/src/wallets/in-app/web/lib/auth/index.ts 1.36% <ø> (ø)

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@gregfromstl gregfromstl changed the title Winston/cnct 2314 consolidate documentation for in app wallets and ecosystem [Portal] Docs: Winston/cnct 2314 consolidate documentation for in app wallets and ecosystem Nov 18, 2024
| SOLUTION | BEST FOR | PRICING |
|----------|----------|----------|
| Connect | Applications needing traditional EOA wallet integration | Free |
| In-App Wallet | Mainstream applications requiring seamless onboarding | [Free up to 1,000 MAW, then $0.02/MAW](https://thirdweb.com/pricing) |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only 1,000? I thought it was a lot more than that? Also I think it's just wallets not monthly active, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya it's 1k on the free tier

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 11:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 11:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 11:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 19, 2024 11:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 19, 2024 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 21:10 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www November 19, 2024 21:10 Inactive
@joaquim-verges joaquim-verges added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 19, 2024
Copy link
Member

joaquim-verges commented Nov 19, 2024

Merge activity

  • Nov 19, 5:30 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 19, 5:30 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 19, 5:42 PM EST: A user merged this pull request with the Graphite merge queue.

… wallets and ecosystem (#5443)

https://linear.app/thirdweb/issue/CNCT-2314/consolidate-documentation-for-in-app-wallets-and-ecosystem

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on restructuring and updating the documentation and components related to `thirdweb` wallets, including `In-App`, `Ecosystem`, and `External Wallets`. It includes deletions of outdated files and additions of new guides and features.

### Detailed summary
- Deleted multiple outdated `.mdx` files related to `In-App Wallet` and `Ecosystem` documentation.
- Added new images and updated asset paths for wallet-related components.
- Introduced a new `AuthList` component to display various authentication methods.
- Updated wallet security documentation to reflect changes in architecture.
- Enhanced the sidebar for better navigation of wallet-related topics.
- Revised various guides to improve clarity on wallet integration and user management.
- Added detailed sections on wallet pregeneration and linking multiple identities.
- Updated the `sign-in methods` documentation with clearer instructions and links.

> The following files were skipped due to too many changes: `apps/portal/src/app/connect/sidebar.tsx`, `apps/portal/src/app/connect/wallet/faq/page.mdx`, `apps/portal/src/app/connect/wallet/user-management/get-user-profiles/page.mdx`, `apps/portal/redirects.mjs`, `apps/portal/src/app/connect/wallet/security/assets/ecosystem-scoped.svg`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants