Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 19, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on refactoring and enhancing the dashboard application by improving component structures, updating styling, and replacing certain components for better functionality and clarity.

Detailed summary

  • Removed toNumber function from utils/number.ts.
  • Updated text styles in empty-chart-state.tsx.
  • Adjusted padding and alignment in EcosystemWalletUsersChartCard.tsx.
  • Streamlined layout in page.tsx files for better structure.
  • Replaced InAppWalletUsersChartCard with InAppWalletUsersChartCardUI.
  • Added new props for TotalSponsoredChartCardUI in TotalSponsoredCard.
  • Enhanced Usage component to include subscription and account details.
  • Introduced AsyncInAppWalletUsersChartCard for asynchronous data fetching.
  • Updated various components to improve readability and maintainability.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 18:25 Inactive
@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 7:09pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 19, 2024 7:09pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 19, 2024 7:09pm
wallet-ui ⬜️ Skipped (Inspect) Nov 19, 2024 7:09pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 18:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 18:25 Inactive
@MananTank MananTank marked this pull request as ready for review November 19, 2024 18:25
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 19, 2024
Copy link
Member Author

MananTank commented Nov 19, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.53%. Comparing base (e0eea33) to head (0ab00f4).
Report is 5 commits behind head on 11-14-integrate_billing_v2_init.

Additional details and impacted files
@@                       Coverage Diff                        @@
##           11-14-integrate_billing_v2_init    #5459   +/-   ##
================================================================
  Coverage                            45.53%   45.53%           
================================================================
  Files                                 1070     1070           
  Lines                                55709    55709           
  Branches                              4031     4031           
================================================================
  Hits                                 25365    25365           
  Misses                               29657    29657           
  Partials                               687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c22380f
packages 40.64% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

---- 🚨 Try these New Features:

@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.9 KB (0%) 899 ms (0%) 775 ms (+45.21% 🔺) 1.7 s
thirdweb (cjs) 105.02 KB (0%) 2.2 s (0%) 782 ms (+30.06% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.61 KB (0%) 113 ms (0%) 14 ms (-22.35% 🔽) 126 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 21 ms (+64.57% 🔺) 31 ms
thirdweb/react (minimal + tree-shaking) 18.41 KB (0%) 369 ms (0%) 101 ms (-9.07% 🔽) 469 ms

@MananTank MananTank force-pushed the 11-14-integrate_billing_v2_init branch from 70790b9 to c22380f Compare November 19, 2024 18:37
@MananTank MananTank force-pushed the 11-19-add_charts_on_usage_page branch from 89eb850 to 0ab00f4 Compare November 19, 2024 18:37
@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 0ab00f4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 19, 2024 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 19, 2024 18:37 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 19, 2024 18:37 Inactive
@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch 4 times, most recently from d6527e3 to 6a02e8c Compare November 19, 2024 19:48
trendFn?: (d: typeof data, key: K) => number | undefined;
existingQueryParams?: { [key: string]: string | string[] | undefined };
className?: string;
hideTabs?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to use the BarChart component directly if you don't need the tabs?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I can make that change

@jnsdls jnsdls force-pushed the 11-14-integrate_billing_v2_init branch from 6a02e8c to bfa7449 Compare November 19, 2024 20:21
@jnsdls
Copy link
Member

jnsdls commented Nov 19, 2024

folded into upstream

@jnsdls jnsdls closed this Nov 19, 2024
@MananTank MananTank deleted the 11-19-add_charts_on_usage_page branch December 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants