[SDK] Fix: PayEmbed Error State #5463
Merged
+73
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
added
the
Bug
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: f368793 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+159
to
+163
| console.log("BuyScreenContent"); | ||
|
|
||
| const activeAccount = useActiveAccount(); | ||
| const { payer, setPayer } = usePayerSetup(); | ||
| console.log("payer", payer); |
Contributor
There was a problem hiding this comment.
Please remove the console.log statements on lines 159 and 162. These appear to be debugging statements that were inadvertently committed. The codebase should remain free of development logging in production.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5463 +/- ##
==========================================
- Coverage 45.52% 45.49% -0.04%
==========================================
Files 1070 1070
Lines 55718 55770 +52
Branches 4029 4034 +5
==========================================
+ Hits 25367 25372 +5
- Misses 29664 29711 +47
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Nov 19, 2024
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
CNCT-2385 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving error handling and user experience in the `BuyScreen` and `TransactionModeScreen` components of the `thirdweb` package. It adds error states for loading issues and modifies error messages for better clarity. ### Detailed summary - Updated error message for missing account in `useBuyTxStates.ts`. - Introduced an error state in `BuyScreen` for `supportedDestinationsQuery` failures. - Added loading and error handling in `TransactionModeScreen` for transaction cost and chain data. - Enhanced user feedback with `ErrorState` and `LoadingScreen` components. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2385-payembed-with-transaction-mode-does-not-have-an-error-state
branch
from
5d9a1b3 to
f368793
Compare
graphite-app
bot
deleted the
greg/cnct-2385-payembed-with-transaction-mode-does-not-have-an-error-state
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2385
PR-Codex overview
This PR focuses on enhancing error handling in the
BuyandTransactionModeScreencomponents of thethirdwebpackage. It improves user experience by providing clearer error messages and loading states.Detailed summary
"No account"to"No payer account found"inuseBuyTxStates.ts.supportedDestinationsQueryinBuyScreen.tsx.TransactionModeScreenwith appropriate user feedback.BuyScreenContent.