-
Notifications
You must be signed in to change notification settings - Fork 619
Version Packages #5465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Packages #5465
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5465 +/- ##
==========================================
- Coverage 43.88% 43.86% -0.03%
==========================================
Files 1075 1076 +1
Lines 55944 55972 +28
Branches 3909 3910 +1
==========================================
+ Hits 24550 24551 +1
- Misses 30711 30738 +27
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
05ff654 to
0cbbf8c
Compare
0cbbf8c to
2ae9e21
Compare
| <NFTProvider contract={contract} tokenId={0n}> | ||
| <NFTMedia | ||
| loadingComponent={<span>Loading NFT Image</span>} | ||
| fallbackComponent={<span>Failed to load NFT</span>} | ||
| /> | ||
| <NFTDescription | ||
| loadingComponent={<span>Loading NFT Description</span>} | ||
| fallbackComponent={<span>Failed to load NFT Description</span>} | ||
| /> | ||
| </NFT> | ||
| ``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The closing tag </NFT> in the example code doesn't match the opening <NFTProvider> tag. This mismatch should be corrected to </NFTProvider> to ensure the example works correctly when copied into production code.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
0be6379 to
926dd90
Compare
926dd90 to
b7eb8f5
Compare
b7eb8f5 to
a7a9ed2
Compare
a7a9ed2 to
3f615f4
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
[email protected]
Minor Changes
#5388
901c3a1Thanks @kien-ngo! - Add headless UI component: Account (Name, Image, Address, Balance)#5374
0e5d120Thanks @joaquim-verges! - # Breaking changeWe are making the following changes to the NFT component to provide better performance and fine-grain control over their internal fetching logic.
Moreover, you no longer have to wrap React.Suspense around said components!
Old
New
The new version comes with 2 new props:
loadingComponentandfallbackComponent.Basically,
loadingComponenttakes in a component and show it while the internal fetching is being donefallbackComponenttakes in a component and show it once the data is failed to be resolvedPatch Changes
#5463
f368793Thanks @gregfromstl! - Fixes PayEmbed error state appearing on certain errors#5464
b5227c9Thanks @gregfromstl! - Adds the ability to override transaction values in createNewPack@thirdweb-dev/[email protected]
Patch Changes
6bd9683Thanks @arcoraven! - chore: Allow optional includeUsage (default: true)PR-Codex overview
This PR focuses on updating the versions of the
thirdweband@thirdweb-dev/service-utilspackages, along with significant changes in theCHANGELOG.mdfiles. It introduces new features, improvements, and fixes in the components.Detailed summary
thirdwebversion from5.69.0to5.70.0.@thirdweb-dev/service-utilsversion from0.4.49to0.4.50.Accountheadless UI component.loadingComponentandfallbackComponentfor theNFTcomponent.NFTcomponent.createNewPack.