Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Nov 19, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

[email protected]

Minor Changes

  • #5388 901c3a1 Thanks @kien-ngo! - Add headless UI component: Account (Name, Image, Address, Balance)

  • #5374 0e5d120 Thanks @joaquim-verges! - # Breaking change

    We are making the following changes to the NFT component to provide better performance and fine-grain control over their internal fetching logic.
    Moreover, you no longer have to wrap React.Suspense around said components!

    Old

    <NFT>
      <React.Suspense fallback={"Loading stuff..."}>
        <NFT.Media />
        <NFT.Name />
        <NFT.Description />
      </React.Suspense>
    </NFT>

    New

    The new version comes with 2 new props: loadingComponent and fallbackComponent.
    Basically, loadingComponent takes in a component and show it while the internal fetching is being done
    fallbackComponent takes in a component and show it once the data is failed to be resolved

    <NFTProvider contract={contract} tokenId={0n}>
        <NFTMedia
          loadingComponent={<span>Loading NFT Image</span>}
          fallbackComponent={<span>Failed to load NFT</span>}
        />
        <NFTDescription
          loadingComponent={<span>Loading NFT Description</span>}
          fallbackComponent={<span>Failed to load NFT Description</span>}
        />
    </NFT>

Patch Changes

@thirdweb-dev/[email protected]

Patch Changes


PR-Codex overview

This PR focuses on updating the versions of the thirdweb and @thirdweb-dev/service-utils packages, along with significant changes in the CHANGELOG.md files. It introduces new features, improvements, and fixes in the components.

Detailed summary

  • Updated thirdweb version from 5.69.0 to 5.70.0.
  • Updated @thirdweb-dev/service-utils version from 0.4.49 to 0.4.50.
  • Added a new Account headless UI component.
  • Introduced new props loadingComponent and fallbackComponent for the NFT component.
  • Improved performance and fetching logic of the NFT component.
  • Fixed PayEmbed error state in certain scenarios.
  • Added ability to override transaction values in createNewPack.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:36am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:36am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:36am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 21, 2024 5:36am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 19, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Nov 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 542 ms (+54.65% 🔺) 1.5 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 985 ms (+44.74% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 244 ms (+308.37% 🔺) 356 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 27 ms (+92.88% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 151 ms (+129.32% 🔺) 518 ms

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.86%. Comparing base (6bd9683) to head (3f615f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5465      +/-   ##
==========================================
- Coverage   43.88%   43.86%   -0.03%     
==========================================
  Files        1075     1076       +1     
  Lines       55944    55972      +28     
  Branches     3909     3910       +1     
==========================================
+ Hits        24550    24551       +1     
- Misses      30711    30738      +27     
  Partials      683      683              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 6bd9683
packages 38.59% <ø> (-0.03%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 1 file with indirect coverage changes

---- 🚨 Try these New Features:

Comment on lines +31 to +43
<NFTProvider contract={contract} tokenId={0n}>
<NFTMedia
loadingComponent={<span>Loading NFT Image</span>}
fallbackComponent={<span>Failed to load NFT</span>}
/>
<NFTDescription
loadingComponent={<span>Loading NFT Description</span>}
fallbackComponent={<span>Failed to load NFT Description</span>}
/>
</NFT>
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The closing tag </NFT> in the example code doesn't match the opening <NFTProvider> tag. This mismatch should be corrected to </NFTProvider> to ensure the example works correctly when copied into production code.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants