[SDK] Fix: Adds overrides to createNewPack #5464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
added
the
Bug
🦋 Changeset detectedLatest commit: b5227c9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
joaquim-verges
approved these changes
Nov 19, 2024
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5464 +/- ##
==========================================
- Coverage 45.82% 45.52% -0.30%
==========================================
Files 1069 1070 +1
Lines 55357 55718 +361
Branches 4032 4029 -3
==========================================
+ Hits 25366 25367 +1
- Misses 29304 29664 +360
Partials 687 687
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
CNCT-2230 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the ability to override transaction values in the `createNewPack` function within the `thirdweb` package. ### Detailed summary - Added `WithOverrides` type to the `options` parameter in `createNewPack` and `getCreatePackParams` functions. - Updated the function signatures to accept overrides for transaction options. - Included `overrides` in the parameters for creating pack details. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2230-execution-reverted-on-pack-creation
branch
from
002092c to
b5227c9
Compare
graphite-app
bot
deleted the
greg/cnct-2230-execution-reverted-on-pack-creation
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2230
PR-Codex overview
This PR introduces the ability to override transaction values in the
createNewPackfunction within thethirdwebpackage.Detailed summary
WithOverridestype to theoptionsparameter increateNewPack.getCreatePackParamsfunction to acceptWithOverrides<BaseTransactionOptions<CreateNewPackParams>>.overridesin the parameters returned bygetCreatePackParams.