[Dashboard] Improve team overview page load perf + UI adjustments #5475
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5475 +/- ##
=======================================
Coverage 43.88% 43.88%
=======================================
Files 1075 1075
Lines 55944 55944
Branches 3910 3910
=======================================
Hits 24550 24550
Misses 30711 30711
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
Contributor
size-limit report 📦
|
MananTank
force-pushed
the
11-21-improve_team_overview_page_load_perf_ui_adjustments
branch
from
5006115 to
642e3d8
Compare
MananTank
changed the title
jnsdls
approved these changes
Nov 20, 2024
Contributor
Merge activity
|
) Move the chart data fetching inside suspense boundary with loading fallback to speed up page load <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving the layout and structure of several components in the dashboard, enhancing the user interface by adjusting styles and adding new features like loading states. It also refines the `TeamOverviewPage` to better handle data and display. ### Detailed summary - Updated styles in `range-selector.tsx` for improved layout. - Added `w-full` class in `EmptyState.tsx` for full-width section. - Adjusted gap sizes in `AnalyticsHeader.tsx`. - Modified `TeamOverviewPage` to include a loading state using `Suspense`. - Introduced `OverviewPageContent` function to manage content rendering. - Enhanced conditionals to simplify rendering logic in `TeamOverviewPage`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
11-21-improve_team_overview_page_load_perf_ui_adjustments
branch
from
642e3d8 to
b52049c
Compare
graphite-app
bot
deleted the
11-21-improve_team_overview_page_load_perf_ui_adjustments
branch
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the chart data fetching inside suspense boundary with loading fallback to speed up page load
PR-Codex overview
This PR focuses on improving the layout and structure of various components in the dashboard, enhancing the user interface and experience. It also introduces a loading state and refines the handling of search parameters in the
TeamOverviewPage.Detailed summary
range-selectorlayout for better spacing.EmptyStatesection to use full width.AnalyticsHeaderstyles and title size.GenericLoadingPagefor loading states.TeamOverviewPageto handle search parameters as promises.TeamOverviewPagefor better organization and readability.