[SDK] Fix props for TokenIcon component #5493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d9a63a6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
kien-ngo
added
the
hotfix
Graphite App
Contributor
Author
Merge activity
|
kien-ngo
force-pushed
the
kien/fix-token-icon-props
branch
from
dfe1f8d to
3ee4b1d
Compare
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5493 +/- ##
=======================================
Coverage 43.85% 43.85%
=======================================
Files 1075 1075
Lines 55944 55944
Branches 3907 3908 +1
=======================================
Hits 24534 24534
Misses 30727 30727
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
MananTank
approved these changes
Nov 22, 2024
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on fixing the issue where properties were not being passed correctly to the `TokenIcon` component.
### Detailed summary
- Updated the return statement in the `Token/icon.tsx` file.
- Changed `return <img src={iconQuery.data} alt={restProps.alt} />;` to `return <img src={iconQuery.data} {...restProps} alt={restProps.alt} />;` to ensure all `restProps` are included in the rendered `img` element.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/fix-token-icon-props
branch
from
3ee4b1d to
d9a63a6
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on fixing an issue where props were not being passed correctly to the
TokenIconcomponent.Detailed summary
Token/icon.tsxfile.<img src={iconQuery.data} alt={restProps.alt} />to<img src={iconQuery.data} {...restProps} alt={restProps.alt} />to ensure allrestPropsare applied to theimgelement.