[SDK] Chain headless components #5495
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d1845f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
64d6599 to
3a120f7
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
3a120f7 to
1417310
Compare
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5495 +/- ##
==========================================
+ Coverage 43.81% 43.84% +0.02%
==========================================
Files 1075 1081 +6
Lines 55991 56186 +195
Branches 3908 3929 +21
==========================================
+ Hits 24534 24635 +101
- Misses 30774 30868 +94
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
1417310 to
c96fca8
Compare
github-actions
bot
added
the
Portal
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
c96fca8 to
da9bdb1
Compare
joaquim-verges
requested changes
Nov 23, 2024
| export interface ChainIconProps | ||
| extends Omit<React.ImgHTMLAttributes<HTMLImageElement>, "src"> { | ||
| /** | ||
| * While marked as "optional", you should pass a ThirdwebClient to this prop |
Contributor
Author
There was a problem hiding this comment.
Updated to make it mandatory
| if (!cid) { | ||
| throw new Error(`Failed to resolve IPFS CID from ${possibleUrl}`); | ||
| } | ||
| return `https://ipfs.io/ipfs/${cid}`; |
Member
There was a problem hiding this comment.
Would not hardcode this. Keep it consistent with the rest of the SDK. If you want ipfs, you need a client
| ...restProps | ||
| }: ChainNameProps) { | ||
| const { chain } = useChainContext(); | ||
| const nameQuery = useQuery({ |
Member
There was a problem hiding this comment.
How come we're not using our existing chain hooks here? Otherwise it's not sharing the cache with the rest of the sdk
Contributor
Author
There was a problem hiding this comment.
I got a couple of reasons:
- getChainMetadata is already catched (using withCache)
- I need to add extra logic to the queryFn, using useChainMetadata wouldn't give me what I want (and users won't be able to customize it)
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
da9bdb1 to
523ffea
Compare
joaquim-verges
approved these changes
Nov 24, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces headless components related to blockchain chain management in the `thirdweb` library, including `ChainProvider`, `ChainIcon`, and `ChainName`. It also adds tests for these components and updates documentation to reflect their usage.
### Detailed summary
- Added headless components: `ChainProvider`, `ChainIcon`, `ChainName`.
- Introduced `TokenIconProps` interface.
- Updated `react.ts` to export new components and their props.
- Added documentation for `ChainProvider`, `ChainIcon`, and `ChainName` in `page.mdx`.
- Implemented tests for `TokenSymbol`, `ChainProvider`, `TokenProvider`, `ChainName`.
- Enhanced `ChainProvider` and `ChainIcon` components with new props and functionalities.
- Updated `ChainName` component to support custom name resolvers and formatting functions.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/headless-chain-components
branch
from
523ffea to
d1845f3
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces new headless components in the
thirdwebpackage, specificallyChainProvider,ChainIcon, andChainName, along with their respective props and functionalities. It also includes tests for these components to ensure proper rendering and data handling.Detailed summary
ChainProvider,ChainIcon, andChainNamecomponents.TokenIcon,ChainProvider,ChainIcon, andChainName.TokenSymbol,ChainProvider,TokenProvider,ChainName, andChainIconcomponents.apps/portal/src/app/react/v5/components/onchain/page.mdx.