Winston/cnct 2363 export private key not working with connectbutton #5498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 6b6f617 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Nov 22, 2024
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5498 +/- ##
==========================================
- Coverage 43.85% 43.82% -0.03%
==========================================
Files 1075 1075
Lines 55944 55991 +47
Branches 3908 3907 -1
==========================================
+ Hits 24534 24539 +5
- Misses 30727 30769 +42
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
…5498) https://linear.app/thirdweb/issue/CNCT-2363/export-private-key-not-working-with-connectbutton <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the ability to export private keys for enclave wallets upon initial login, enhancing wallet management functionality. ### Detailed summary - Added `connectLocale` prop to the `PrivateKey` component. - Implemented `useEffect` to handle postMessage for private key export. - Changed base domain retrieval to use `getThirdwebBaseUrl`. - Updated `ModalHeader` title to use localized string. - Set iframe ID dynamically based on wallet ID. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2363-export-private-key-not-working-with-connectbutton
branch
from
3a5e4a6 to
6b6f617
Compare
graphite-app
bot
deleted the
winston/cnct-2363-export-private-key-not-working-with-connectbutton
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2363/export-private-key-not-working-with-connectbutton
PR-Codex overview
This PR enables private key export for enclave wallets during the initial login process, enhancing user experience and security.
Detailed summary
connectLocaleprop toPrivateKeycomponent.useEffectto handle iframe messaging for private key export.getThirdwebDomainswithgetThirdwebBaseUrl.ModalHeadertitle to use localized text.idfor exporting the wallet.