[SDK] Feature: Export contract deployment utilities #5501
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ac42c45 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
.changeset/long-queens-draw.md
Outdated
| }); | ||
|
|
||
| // Get default constructor params | ||
| const params = await getAllDefaultConstructorParamsForImplementation({ |
Member
There was a problem hiding this comment.
can we keep this one un-exported? i actually want to get rid of it in favor of what yash is working on
| }); | ||
|
|
||
| // Get or deploy infrastructure | ||
| const infra = await getOrDeployInfraForPublishedContract({ |
Member
There was a problem hiding this comment.
maybe we just expose this one for now? instead of getDeployedInfraContract and getDeployedCloneFactory ?
joaquim-verges
approved these changes
Nov 23, 2024
.changeset/long-queens-draw.md
Outdated
| } from "thirdweb"; | ||
|
|
||
| // Get deployed clone factory | ||
| const factory = await getDeployedCloneFactoryContract({ |
Member
There was a problem hiding this comment.
nit: remove these from the changeset
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5501 +/- ##
==========================================
- Coverage 44.09% 43.82% -0.28%
==========================================
Files 1074 1075 +1
Lines 55632 55991 +359
Branches 3907 3909 +2
==========================================
+ Hits 24533 24539 +6
- Misses 30416 30769 +353
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
gregfromstl
added a commit
that referenced
this pull request
Nov 23, 2024
CNCT-2441 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces new utility functions to enhance the management of infrastructure contracts and initialization processes within the `thirdweb` SDK. It also adds detailed documentation for several existing and new functions. ### Detailed summary - Added `getInitializeTransaction` for preparing contract initialization transactions. - Added `getOrDeployInfraForPublishedContract` to manage infrastructure for published contracts. - Documented `getDeployedCloneFactoryContract` with details on its parameters and return values. - Documented `getAllDefaultConstructorParamsForImplementation` for obtaining default constructor parameters. - Documented `getDeployedInfraContract` to retrieve infrastructure contract instances. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2441-provide-code-snippet-for-current-api-usage-of-prepare-deploy
branch
from
8ffb741 to
600c024
Compare
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
CNCT-2441 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces new utility functions and enhances existing ones to improve the management of infrastructure contracts and initialization processes within the `thirdweb` framework. ### Detailed summary - Added `getInitializeTransaction` for preparing contract initialization transactions. - Added `getOrDeployInfraForPublishedContract` to manage infrastructure for published contracts. - Documented various functions with detailed JSDoc comments. - Enhanced `getDeployedCloneFactoryContract` and `getDeployedInfraContract` with clearer descriptions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2441-provide-code-snippet-for-current-api-usage-of-prepare-deploy
branch
from
f28e239 to
ac42c45
Compare
graphite-app
bot
removed
the
merge-queue
gregfromstl
added
the
merge-queue
graphite-app
bot
deleted the
greg/cnct-2441-provide-code-snippet-for-current-api-usage-of-prepare-deploy
branch
Merged
Contributor
Author
|
changelog |
2 similar comments
Contributor
Author
|
changelog |
Contributor
Author
|
changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2441
PR-Codex overview
This PR introduces new utility functions for managing infrastructure contracts and contract initialization in the
thirdwebSDK, enhancing the deployment process for published contracts.Detailed summary
getInitializeTransactionfor preparing contract initialization transactions.getOrDeployInfraForPublishedContractto retrieve or deploy infrastructure for published contracts.getDeployedCloneFactoryContractto retrieve deployed clone factory instances.getAllDefaultConstructorParamsForImplementationto fetch default constructor parameters for contract deployments.getDeployedInfraContractfunction with detailed parameter descriptions.