Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 25, 2024

CNCT-2462


PR-Codex overview

This PR introduces a new GitHub Actions workflow named Linked Issue, which checks if a pull request body contains a valid issue reference with specified prefixes.

Detailed summary

  • Added a new workflow file issue.yml for pull request validation.
  • Defined VALID_ISSUE_PREFIXES environment variable to allow specific prefixes.
  • Implemented a job linear that checks for issue references in the PR body.
  • Used a regular expression to validate the presence of issue IDs.
  • Set a failure message if no valid issue reference is found.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 25, 2024

@vercel
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:41pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:41pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:41pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2024 7:41pm

@changeset-bot
Copy link

changeset-bot bot commented Nov 25, 2024

⚠️ No Changeset found

Latest commit: 0e98b09

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.97 KB (0%) 900 ms (0%) 2.5 s (+47.5% 🔺) 3.4 s
thirdweb (cjs) 105.01 KB (0%) 2.2 s (0%) 3.7 s (+10.42% 🔺) 5.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 113 ms (0%) 237 ms (+32.81% 🔺) 349 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (-31.18% 🔽) 36 ms
thirdweb/react (minimal + tree-shaking) 18.38 KB (0%) 368 ms (0%) 300 ms (-31.03% 🔽) 668 ms

@codecov
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.84%. Comparing base (46c3abb) to head (0e98b09).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5508   +/-   ##
=======================================
  Coverage   43.84%   43.84%           
=======================================
  Files        1081     1081           
  Lines       56186    56186           
  Branches     3929     3929           
=======================================
  Hits        24635    24635           
  Misses      30868    30868           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 46c3abb
packages 38.60% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 25, 2024
Copy link
Contributor Author

Merge activity

  • Nov 25, 2:36 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 25, 2024

Merge activity

CNCT-2462
<!-- start pr-codex -->

## PR-Codex overview
This PR introduces a new GitHub Actions workflow named `Linked Issue`, which checks for valid issue references in the pull request body. It ensures that the body contains an issue ID with specified prefixes before allowing the pull request to proceed.

### Detailed summary
- Added a new workflow file named `issue.yml`.
- Set the workflow to trigger on `pull_request` events (opened, edited).
- Defined an environment variable `VALID_ISSUE_PREFIXES` with values "CNCT|DASH".
- Created a job named `linear` that runs on `ubuntu-latest`.
- Implemented a step to check for linked issue references in the PR body using a regex.
- If no valid reference is found, the workflow fails with a specific error message.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants