Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Nov 26, 2024

Fixes: DASH-480

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 26, 2024 10:48pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Nov 26, 2024 10:48pm
thirdweb_playground ⬜️ Skipped (Inspect) Nov 26, 2024 10:48pm
wallet-ui ⬜️ Skipped (Inspect) Nov 26, 2024 10:48pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 21:27 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 21:27 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: e323073

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Nov 26, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Nov 26, 2024

@MananTank MananTank marked this pull request as ready for review November 26, 2024 21:28
@codecov
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.18%. Comparing base (ee2b8e5) to head (e323073).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5528   +/-   ##
=======================================
  Coverage   46.18%   46.18%           
=======================================
  Files        1083     1083           
  Lines       58683    58683           
  Branches     3936     3936           
=======================================
  Hits        27105    27105           
  Misses      30895    30895           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ee2b8e5
packages 41.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank changed the title Dashboard Remove unused assets [Dashboard] Remove unused assets Nov 26, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 26, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 3.9 s (+39.22% 🔺) 4.8 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 6.6 s (+0.67% 🔺) 8.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 224 ms (-20.27% 🔽) 336 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (-68.19% 🔽) 51 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 366 ms (0%) 825 ms (+103.51% 🔺) 1.2 s

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approved pending manual checks

@MananTank MananTank force-pushed the 11-27-dashboard_remove_unused_assets branch from a2ffcc7 to e323073 Compare November 26, 2024 22:39
@vercel vercel bot temporarily deployed to Preview – wallet-ui November 26, 2024 22:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 November 26, 2024 22:39 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground November 26, 2024 22:39 Inactive
@jnsdls jnsdls merged commit f64e025 into main Nov 26, 2024
31 checks passed
@jnsdls jnsdls deleted the 11-27-dashboard_remove_unused_assets branch November 26, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants