[SDK] Feature: Adds Multiwrap and LoyaltyCard Extensions #5529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7488102 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5529 +/- ##
==========================================
- Coverage 46.20% 46.19% -0.01%
==========================================
Files 1080 1081 +1
Lines 58569 58613 +44
Branches 3929 3933 +4
==========================================
+ Hits 27060 27075 +15
- Misses 30826 30855 +29
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
| [ | ||
| "constructor()", | ||
| "function cancel(uint256 tokenId)", | ||
| "function initialize(address _defaultAdmin, string _name, string _symbol, string _contractURI, address[] _trustedForwarders, address _saleRecipient, address _royaltyRecipient, uint128 _royaltyBps, uint128 _platformFeeBps, address _platformFeeRecipient)", |
Member
There was a problem hiding this comment.
we only need this function here, everything else is duplicates
joaquim-verges
approved these changes
Nov 27, 2024
gregfromstl
removed
the
merge-queue
gregfromstl
added
the
merge-queue
CNCT-2438 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces enhancements to the `thirdweb` library by adding support for a new `LoyaltyCard` extension, improving event handling, and updating the `github_checks` workflow to validate PR branches for issue references. ### Detailed summary - Added `ignore` pattern in `codecov.yml`. - Updated `issue.yml` to check PR body and branch name for valid issue references. - Implemented `LoyaltyCard` extension with deployment support and event handling. - Added new functions for `TokensMinted`, `TokensUnwrapped`, and `TokensWrapped` events. - Updated `Multiwrap` and `LoyaltyCard` ABIs. - Added tests for deploying `LoyaltyCard` and other ERC721 types. > The following files were skipped due to too many changes: `packages/thirdweb/src/extensions/erc721/__generated__/Multiwrap/write/unwrap.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/Multiwrap/write/wrap.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/LoyaltyCard/write/mintWithSignature.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/Multiwrap/write/initialize.ts`, `packages/thirdweb/src/extensions/erc721/__generated__/LoyaltyCard/write/initialize.ts` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2438-add-multiwrap-and-loyaltycard-to-erc721contracttype
branch
from
b5f33c2 to
7488102
Compare
graphite-app
bot
deleted the
greg/cnct-2438-add-multiwrap-and-loyaltycard-to-erc721contracttype
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2438
PR-Codex overview
This PR introduces the
LoyaltyCardextension for theERC721contract, enhancing the functionality for deploying loyalty card NFTs, and updates various related methods and events.Detailed summary
ignorerule incodecov.ymlfor generated files..github/workflows/issue.yml.LoyaltyCardwith deployment and event handling.LoyaltyCardandMultiwrap.cancel,revoke,mintTo, andunwrapinLoyaltyCard.TokensMinted,TokensWrapped, andTokensUnwrapped.LoyaltyCardand other ERC721 types.