Skip to content

Conversation

@gregfromstl
Copy link
Contributor

@gregfromstl gregfromstl commented Nov 26, 2024

CNCT-2485


PR-Codex overview

This PR focuses on improving code coverage requirements and updating the CI workflow for better clarity and functionality.

Detailed summary

  • Updated codecov.yml to set the coverage target to 80%.
  • Renamed the CI workflow step from Upload coverage reports to Codecov to Code Coverage.
  • Adjusted the uses directive for the Codecov action to codecov/codecov-action@v5.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Nov 26, 2024

@changeset-bot
Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: 9d3c8ac

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:01am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:01am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:01am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2024 0:01am

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 26, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 27, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 597 ms (+7.1% 🔺) 1.6 s
thirdweb (cjs) 107.27 KB (0%) 2.2 s (0%) 1.4 s (+4.7% 🔺) 3.6 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 113 ms (+157.1% 🔺) 225 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 15 ms (+48.1% 🔺) 25 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 141 ms (-22.45% 🔽) 507 ms

@codecov
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.20%. Comparing base (f64e025) to head (9d3c8ac).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5530   +/-   ##
=======================================
  Coverage   46.20%   46.20%           
=======================================
  Files        1080     1080           
  Lines       58569    58569           
  Branches     3929     3929           
=======================================
  Hits        27060    27060           
  Misses      30826    30826           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f64e025
packages 41.75% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@gregfromstl gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Nov 27, 2024
Copy link
Contributor Author

gregfromstl commented Nov 27, 2024

Merge activity

  • Nov 27, 6:57 AM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 27, 6:57 AM EST: A user added this pull request to the Graphite merge queue.
  • Nov 27, 7:01 AM EST: A user merged this pull request with the Graphite merge queue.

CNCT-2485

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the code coverage settings and the GitHub Actions workflow for better integration with Codecov.

### Detailed summary
- Updated `codecov.yml` to set `target` coverage to `80%` instead of `auto`.
- Modified `.github/workflows/CI.yml`:
  - Changed the step name from `Upload coverage reports to Codecov` to `Code Coverage`.
  - Specified the `directory` for coverage reports as `packages/`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants