-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Refactor: Ox Transaction Envelopes #5546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Refactor: Ox Transaction Envelopes #5546
Conversation
Fixes: DASH-487 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating references to smart contract interaction links throughout the application, simplifying the URLs to point directly to `/contracts` instead of specific interaction overview pages. ### Detailed summary - Updated `href` in `page.tsx` from `/contracts/interact/overview` to `/contracts`. - Changed references in `interact-blockchain/page.mdx` to point to `/contracts`. - Modified links in `contracts/page.mdx` to `/contracts`. - Adjusted links in `sdk.tsx` to `https://portal.thirdweb.com/contracts`. - Updated SDK documentation links in `ipfs/page.mdx` to `/contracts`. - Changed SDK references in `gas/page.mdx` to `/contracts`. - Updated redirects in `redirects.mjs` for `/sdk`, `/sdk/how-it-works`, and `/sdk/getting-started` to `/contracts`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
size-limit report 📦
|
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
part of DASH-388 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the return types in the `convertFiatToCrypto` and `convertCryptoToFiat` functions to return objects instead of plain numbers. Additionally, it modifies the `SnapshotUpload` component to replace `Link` elements with `a` tags and adjusts the layout for better styling. ### Detailed summary - Changed return type of `convertFiatToCrypto` to `{ result: 0.0000057 }`. - Changed return type of `convertCryptoToFiat` to `{ result: 3404.11 }`. - Replaced `Link` components with `a` tags in `SnapshotUpload`. - Adjusted layout and styling in `SnapshotUpload` for improved design. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
PR-Codex overview
This PR focuses on updating the
thirdweband@thirdweb-dev/service-utilspackages, introducing new functionalities for converting fiat to crypto and vice versa, while also improving transaction handling and UI components.Detailed summary
thirdwebversion to5.72.0and@thirdweb-dev/service-utilsto0.4.51.convertFiatToCryptoandconvertCryptoToFiatfunctions.maxPriorityFeePerGasin transactions.promptTokensandcompletionTokensfields in usage tracking.