Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 2, 2024

Fixes DASH-493

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 1:34pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 2, 2024 1:34pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 1:34pm
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 1:34pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 82d077d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 13:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 13:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 13:23 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 2, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 2, 2024

@MananTank MananTank marked this pull request as ready for review December 2, 2024 13:25
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.31%. Comparing base (ebf94a6) to head (82d077d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5551   +/-   ##
=======================================
  Coverage   46.31%   46.31%           
=======================================
  Files        1082     1082           
  Lines       58672    58672           
  Branches     3955     3955           
=======================================
  Hits        27174    27174           
  Misses      30815    30815           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ebf94a6
packages 41.90% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 2.8 s (-21.49% 🔽) 3.8 s
thirdweb (cjs) 107.33 KB (0%) 2.2 s (0%) 5.4 s (+2.97% 🔺) 7.5 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 137 ms (+6.08% 🔺) 249 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 50 ms (-83.34% 🔽) 60 ms
thirdweb/react (minimal + tree-shaking) 18.28 KB (0%) 366 ms (0%) 1.1 s (+113.96% 🔺) 1.5 s

@MananTank MananTank changed the title [Dashboard] - Remove server-only import on files [Dashboard] - Remove server-only import on "use server" files Dec 2, 2024
@MananTank MananTank closed this Dec 2, 2024
@MananTank MananTank deleted the 12-02-_dashboard_-_remove_server-only_import_on_files branch December 18, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants