Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 2, 2024

closes: DASH-501

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: e937680

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:07pm
thirdweb_playground ❌ Failed (Inspect) Dec 2, 2024 9:07pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:07pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:07pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

jnsdls commented Dec 2, 2024

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. packages Ecosystem Portal Involves changes to the Ecosystem Portal SDK Involves changes to the thirdweb SDK labels Dec 2, 2024
@jnsdls jnsdls mentioned this pull request Dec 2, 2024
@jnsdls jnsdls marked this pull request as ready for review December 2, 2024 18:49
@socket-security
Copy link

socket-security bot commented Dec 2, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@cloudflare/[email protected] None 0 4.37 MB asapzacy, celso, cf-ci-write, ...32 more
npm/@sentry/[email protected] environment, filesystem, network Transitive: eval, shell, unsafe +242 70.2 MB sentry-bot
npm/@storybook/[email protected] Transitive: environment, eval +56 24.3 MB storybook-bot
npm/@storybook/[email protected] Transitive: environment +19 7.09 MB storybook-bot
npm/@storybook/[email protected] None +8 583 kB storybook-bot
npm/@storybook/[email protected] None +4 684 kB storybook-bot
npm/@storybook/[email protected] environment Transitive: eval, filesystem, network, shell, unsafe +502 45.2 MB storybook-bot
npm/@storybook/[email protected] Transitive: environment, eval, filesystem, shell, unsafe +79 15 MB storybook-bot
npm/@storybook/[email protected] None +6 938 kB domyen, ghengeveld, jreinhold, ...9 more
npm/@storybook/[email protected] environment, eval +105 16.9 MB storybook-bot
npm/@types/[email protected] None +1 2.37 MB types
npm/@vercel/[email protected] None 0 78.5 kB vercel-release-bot
npm/@vitest/[email protected] Transitive: environment, filesystem, shell +56 10.6 MB antfu, oreanno, patak, ...1 more
npm/@vitest/[email protected] Transitive: filesystem +14 2.24 MB antfu, oreanno, patak, ...1 more
npm/[email protected] environment, eval, filesystem Transitive: network, shell, unsafe +277 48.8 MB checkly-engineering
npm/[email protected] None 0 20.2 kB srbrahma
npm/[email protected] environment +1 3.12 MB popmotion
npm/[email protected] network, shell, unsafe +3 12.7 MB davidortner
npm/[email protected] environment, eval Transitive: filesystem, shell, unsafe +42 5.45 MB webpro
npm/[email protected] None 0 28.5 MB ericfennis
npm/[email protected] network +5 5.74 MB jmoxey
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +87 27 MB ghengeveld, jreinhold, kasperpeulen, ...5 more
npm/[email protected] None 0 14.9 kB jaredpalmer, turbobot, vercel-release-bot
npm/[email protected] Transitive: environment, network +14 22.9 MB awkweb, jmoxey
npm/[email protected] environment, eval, filesystem, network, shell, unsafe +3 5.57 MB vitebot
npm/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +36 10.4 MB antfu, oreanno, patak, ...1 more

🚮 Removed packages: npm/@cloudflare/[email protected], npm/@sentry/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@storybook/[email protected], npm/@tanstack/[email protected], npm/@types/[email protected], npm/@vercel/[email protected], npm/@vitest/[email protected], npm/@vitest/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@jnsdls jnsdls force-pushed the 12-02-remove_and_redirect_old_landing_pages branch from 923acf3 to 71c968b Compare December 2, 2024 18:50
@jnsdls jnsdls force-pushed the 12-02-update_dependencies branch from 15dd3e9 to e937680 Compare December 2, 2024 18:50
@linear
Copy link

linear bot commented Dec 2, 2024

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (+0.01% 🔺) 959 ms (+0.01% 🔺) 519 ms (+56.45% 🔺) 1.5 s
thirdweb (cjs) 107.39 KB (+0.06% 🔺) 2.2 s (+0.06% 🔺) 690 ms (+1.67% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 89 ms (+555.17% 🔺) 201 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 8 ms (-2.13% 🔽) 18 ms
thirdweb/react (minimal + tree-shaking) 18.27 KB (-0.08% 🔽) 366 ms (-0.08% 🔽) 151 ms (+183.44% 🔺) 517 ms

Base automatically changed from 12-02-remove_and_redirect_old_landing_pages to main December 2, 2024 20:43
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.96%. Comparing base (149ee05) to head (e937680).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5554      +/-   ##
==========================================
- Coverage   46.32%   43.96%   -2.36%     
==========================================
  Files        1082     1083       +1     
  Lines       58672    56263    -2409     
  Branches     3950     3955       +5     
==========================================
- Hits        27178    24738    -2440     
- Misses      30811    30842      +31     
  Partials      683      683              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 71c968b
packages 38.76% <ø> (-3.16%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 588 files with indirect coverage changes

@jnsdls jnsdls merged commit 5c55314 into main Dec 2, 2024
31 of 32 checks passed
@jnsdls jnsdls deleted the 12-02-update_dependencies branch December 2, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard. Ecosystem Portal Involves changes to the Ecosystem Portal packages Playground Changes involving the Playground codebase. Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants