Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 2, 2024

DASH-496


PR-Codex overview

This PR primarily focuses on changing the property names for loading states from isLoading to isPending across various components in the codebase, enhancing consistency in the handling of transaction states.

Detailed summary

  • Changed isLoading to isPending in multiple components including:
    • delegate-button.tsx
    • claim-button.tsx
    • proposal-button.tsx
    • module-card.tsx
    • list-form.tsx
    • Transferable.tsx
    • airdrop-form.tsx
    • OpenEditionMetadata.tsx
    • mint-supply-tab.tsx
    • mint-form.tsx
    • BatchMetadata.tsx
    • interactive-abi-function.tsx
    • reveal-button.tsx
    • lazy-mint-form.tsx
    • deposit-native.tsx
    • shared-metadata-form.tsx
    • burn-button.tsx
    • transfer-button.tsx
    • transfer-tab.tsx
    • mint-button.tsx
    • claim-button.tsx
    • ModuleForm.tsx
    • burn-tab.tsx
    • index.tsx
    • cancel-tab.tsx
    • claim-conditions-form/index.tsx
    • create-account-button.tsx
    • Mintable.tsx
    • metadata.tsx
    • royalties.tsx
    • primary-sale.tsx
    • update-metadata-form.tsx
    • platform-fees.tsx
    • Royalty.tsx
    • Claimable.tsx
    • distribute-button.tsx
    • claim-conditions-form/index.tsx
    • claimable.stories.tsx
    • mintable.stories.tsx
    • royalty.stories.tsx
    • TransactionButton.tsx
    • MismatchButton.tsx

The following files were skipped due to too many changes: apps/dashboard/src/components/buttons/MismatchButton.tsx

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2024

⚠️ No Changeset found

Latest commit: 125de5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 18:54 Inactive
@vercel
Copy link

vercel bot commented Dec 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 2, 2024 9:55pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 2, 2024 9:55pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 2, 2024 9:55pm
wallet-ui ⬜️ Skipped (Inspect) Dec 2, 2024 9:55pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 18:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 18:54 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 2, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 2, 2024 18:54
@codecov
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.98%. Comparing base (00d6529) to head (125de5f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5556   +/-   ##
=======================================
  Coverage   43.98%   43.98%           
=======================================
  Files        1082     1082           
  Lines       56235    56235           
  Branches     3954     3954           
=======================================
  Hits        24737    24737           
  Misses      30815    30815           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 00d6529
packages 38.78% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 488 ms (-21.79% 🔽) 1.5 s
thirdweb (cjs) 107.39 KB (0%) 2.2 s (0%) 791 ms (-18.44% 🔽) 3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 150 ms (+52.85% 🔺) 262 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 26 ms (+172.32% 🔺) 36 ms
thirdweb/react (minimal + tree-shaking) 18.27 KB (0%) 366 ms (0%) 134 ms (+1.51% 🔺) 499 ms

@MananTank MananTank force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from 92a5fb1 to a1bea37 Compare December 2, 2024 19:07
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 19:07 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 19:07 Inactive
Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks too clickable / needs some more disabled state when active (cursor is still pointer, too):

image.png

@MananTank MananTank force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from a1bea37 to 37374a8 Compare December 2, 2024 20:46
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 20:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 20:46 Inactive
Copy link
Member Author

disabled the button when its in pending state

@MananTank MananTank requested a review from jnsdls December 2, 2024 20:47
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 2, 2024

Merge activity

jnsdls pushed a commit that referenced this pull request Dec 2, 2024
DASH-496

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on renaming the `isLoading` prop to `isPending` across various `TransactionButton` components in the codebase, improving clarity in the state management of transactions.

### Detailed summary
- Changed `isLoading` prop to `isPending` in multiple `TransactionButton` components.
- Updated related conditional checks and disabled states to reflect the new prop name.
- Adjusted button labels to provide clearer user feedback during pending states.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from 37374a8 to 11eda28 Compare December 2, 2024 21:05
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:05 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:05 Inactive
jnsdls pushed a commit that referenced this pull request Dec 2, 2024
DASH-496

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring the `TransactionButton` component and its usage across various files to replace the `isLoading` prop with `isPending`. This change improves clarity and consistency in handling transaction states.

### Detailed summary
- Replaced `isLoading` with `isPending` in multiple components.
- Updated button states in forms and transaction handlers.
- Enhanced tooltip labels and button styles for better UX.
- Adjusted imports and component structures for consistency.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from 11eda28 to 0b4b355 Compare December 2, 2024 21:08
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:08 Inactive
jnsdls pushed a commit that referenced this pull request Dec 2, 2024
DASH-496

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the usage of the `isLoading` prop to `isPending` in multiple components for better clarity and consistency in handling transaction states.

### Detailed summary
- Replaced `isLoading` with `isPending` in various components, enhancing clarity.
- Updated button states and disabled conditions accordingly.
- Adjusted button styling and layout in several instances to maintain UI consistency.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from 0b4b355 to 88eedf7 Compare December 2, 2024 21:25
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:25 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:25 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:25 Inactive
DASH-496

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating various components in the codebase to replace the `isLoading` prop with `isPending` for better clarity and consistency in handling loading states.

### Detailed summary
- Replaced `isLoading` with `isPending` in multiple components including `delegate-button.tsx`, `claim-button.tsx`, and `proposal-button.tsx`.
- Updated the loading state handling in `TransactionButton` and related components.
- Adjusted styles and props for better UI consistency.
- Modified tooltip labels and button texts to reflect the new loading state terminology.

> The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch from 88eedf7 to 125de5f Compare December 2, 2024 21:45
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 2, 2024 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 2, 2024 21:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 2, 2024 21:45 Inactive
@graphite-app graphite-app bot merged commit 125de5f into main Dec 2, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-03-migrate_transactionbutton_to_shadcn_tailwind branch December 2, 2024 21:57
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 2, 2024 21:57 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 2, 2024 21:57 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 2, 2024 21:57 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants