-
Notifications
You must be signed in to change notification settings - Fork 619
Migrate TransactionButton to shadcn + tailwind #5556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate TransactionButton to shadcn + tailwind #5556
Conversation
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5556 +/- ##
=======================================
Coverage 43.98% 43.98%
=======================================
Files 1082 1082
Lines 56235 56235
Branches 3954 3954
=======================================
Hits 24737 24737
Misses 30815 30815
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
92a5fb1 to
a1bea37
Compare
jnsdls
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a1bea37 to
37374a8
Compare
|
disabled the button when its in pending state |
Merge activity
|
DASH-496 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on renaming the `isLoading` prop to `isPending` across various `TransactionButton` components in the codebase, improving clarity in the state management of transactions. ### Detailed summary - Changed `isLoading` prop to `isPending` in multiple `TransactionButton` components. - Updated related conditional checks and disabled states to reflect the new prop name. - Adjusted button labels to provide clearer user feedback during pending states. > The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
37374a8 to
11eda28
Compare
DASH-496 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `TransactionButton` component and its usage across various files to replace the `isLoading` prop with `isPending`. This change improves clarity and consistency in handling transaction states. ### Detailed summary - Replaced `isLoading` with `isPending` in multiple components. - Updated button states in forms and transaction handlers. - Enhanced tooltip labels and button styles for better UX. - Adjusted imports and component structures for consistency. > The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
11eda28 to
0b4b355
Compare
DASH-496 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the usage of the `isLoading` prop to `isPending` in multiple components for better clarity and consistency in handling transaction states. ### Detailed summary - Replaced `isLoading` with `isPending` in various components, enhancing clarity. - Updated button states and disabled conditions accordingly. - Adjusted button styling and layout in several instances to maintain UI consistency. > The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
0b4b355 to
88eedf7
Compare
DASH-496 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating various components in the codebase to replace the `isLoading` prop with `isPending` for better clarity and consistency in handling loading states. ### Detailed summary - Replaced `isLoading` with `isPending` in multiple components including `delegate-button.tsx`, `claim-button.tsx`, and `proposal-button.tsx`. - Updated the loading state handling in `TransactionButton` and related components. - Adjusted styles and props for better UI consistency. - Modified tooltip labels and button texts to reflect the new loading state terminology. > The following files were skipped due to too many changes: `apps/dashboard/src/components/buttons/MismatchButton.tsx` > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
88eedf7 to
125de5f
Compare


DASH-496
PR-Codex overview
This PR primarily focuses on changing the property names for loading states from
isLoadingtoisPendingacross various components in the codebase, enhancing consistency in the handling of transaction states.Detailed summary
isLoadingtoisPendingin multiple components including:delegate-button.tsxclaim-button.tsxproposal-button.tsxmodule-card.tsxlist-form.tsxTransferable.tsxairdrop-form.tsxOpenEditionMetadata.tsxmint-supply-tab.tsxmint-form.tsxBatchMetadata.tsxinteractive-abi-function.tsxreveal-button.tsxlazy-mint-form.tsxdeposit-native.tsxshared-metadata-form.tsxburn-button.tsxtransfer-button.tsxtransfer-tab.tsxmint-button.tsxclaim-button.tsxModuleForm.tsxburn-tab.tsxindex.tsxcancel-tab.tsxclaim-conditions-form/index.tsxcreate-account-button.tsxMintable.tsxmetadata.tsxroyalties.tsxprimary-sale.tsxupdate-metadata-form.tsxplatform-fees.tsxRoyalty.tsxClaimable.tsxdistribute-button.tsxclaim-conditions-form/index.tsxclaimable.stories.tsxmintable.stories.tsxroyalty.stories.tsxTransactionButton.tsxMismatchButton.tsx