[SDK] Fix: Account switching with connected smart wallets #5592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: c3d7b66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5592 +/- ##
==========================================
+ Coverage 43.98% 44.17% +0.18%
==========================================
Files 1082 1083 +1
Lines 56235 56276 +41
Branches 3954 3975 +21
==========================================
+ Hits 24737 24858 +121
+ Misses 30815 30735 -80
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
github-actions
bot
added
the
Playground
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
| "level": "error" | ||
| } | ||
| }, | ||
| "noUselessElse": "off" |
joaquim-verges
approved these changes
Dec 3, 2024
Fixes #5537 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on improving wallet connection handling in the `thirdweb` project, specifically when switching signer accounts and simplifying connection logic for smart wallets. ### Detailed summary - Updated `biome.json` to add `"noUselessElse": "off"`. - Modified wallet connection logic in `packages/thirdweb/src/wallets/manager/index.ts` for better handling of active wallets. - Added tests for connection management in `packages/thirdweb/src/wallets/manager/connection-manager.test.ts`. - Removed environment variable logging across multiple API routes. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2502-useactiveaccount-bug-when-using-aa
branch
from
838973d to
c3d7b66
Compare
graphite-app
bot
deleted the
greg/cnct-2502-useactiveaccount-bug-when-using-aa
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5537
PR-Codex overview
This PR focuses on enhancing the wallet connection management in the
thirdweblibrary, specifically improving the handling of smart wallets and updating the connection logic for various API routes.Detailed summary
biome.jsonto include"noUselessElse": "off".packages/thirdweb/src/wallets/manager/index.ts.packages/thirdweb/src/wallets/manager/connection-manager.test.ts.