Skip to content

Conversation

@arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Dec 4, 2024

PR-Codex overview

This PR updates the ownership configuration for the apps/portal/ directory in the .github/CODEOWNERS file, changing the assigned users to a new set of teams.

Detailed summary

  • Updated ownership for apps/portal/ from @gregfromstl, @jnsdls, @joaquim-verges, and @MananTank to @thirdweb-dev/product, @thirdweb-dev/platform, and @thirdweb-dev/infra.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from jnsdls as a code owner December 4, 2024 01:42
@vercel
Copy link

vercel bot commented Dec 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:50am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:50am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:50am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 4, 2024 1:50am

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2024

⚠️ No Changeset found

Latest commit: 4325a6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@codecov
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.18%. Comparing base (46bf321) to head (4325a6a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5601   +/-   ##
=======================================
  Coverage   44.18%   44.18%           
=======================================
  Files        1082     1082           
  Lines       56253    56253           
  Branches     3975     3975           
=======================================
  Hits        24857    24857           
  Misses      30713    30713           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 46bf321
packages 39.03% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.92 KB (0%) 959 ms (0%) 1.4 s (-6.51% 🔽) 2.4 s
thirdweb (cjs) 107.39 KB (0%) 2.2 s (0%) 2.9 s (-14.34% 🔽) 5.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 51 ms (-24.57% 🔽) 162 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 62 ms (+165.35% 🔺) 72 ms
thirdweb/react (minimal + tree-shaking) 18.29 KB (0%) 366 ms (0%) 455 ms (+68.68% 🔺) 820 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants