feat: add unlinking for in app wallet accounts #5604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 03b6d0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5604 +/- ##
==========================================
+ Coverage 51.53% 51.65% +0.12%
==========================================
Files 1094 1097 +3
Lines 57592 57788 +196
Branches 4755 4773 +18
==========================================
+ Hits 29681 29853 +172
- Misses 27193 27217 +24
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more.
|
joaquim-verges
approved these changes
Dec 6, 2024
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
ElasticBottle
added a commit
that referenced
this pull request
Dec 12, 2024
https://linear.app/thirdweb/issue/CNCT-2497/unlink-auth-method-for-enclave-wallets <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces functionality to unlink accounts for in-app wallets that have multiple linked profiles, enhancing user account management. ### Detailed summary - Added `UnlinkParams` type for unlinking profiles. - Implemented `unlinkProfile` method in various connectors. - Updated exports to include `unlinkProfile`. - Added hooks (`useUnlinkProfile`) for React and React Native. - Enhanced UI components to support unlinking profiles. - Added tests for unlinking functionality. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2497-unlink-auth-method-for-enclave-wallets
branch
from
fedc0be to
1ac03e9
Compare
graphite-app
bot
removed
the
merge-queue
ElasticBottle
added
the
merge-queue
https://linear.app/thirdweb/issue/CNCT-2497/unlink-auth-method-for-enclave-wallets <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces functionality to unlink accounts from the in-app wallet, allowing users to manage multiple linked profiles more effectively. ### Detailed summary - Added `UnlinkParams` type for unlinking profiles. - Implemented `unlinkProfile` method in `InAppNativeConnector` and `InAppWebConnector`. - Updated `unlinkAccount` function to handle profile unlinking. - Added `useUnlinkProfile` hook for React. - Enhanced `LinkedProfilesScreen` to include unlink buttons when multiple profiles exist. - Added tests for unlinking functionality. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2497-unlink-auth-method-for-enclave-wallets
branch
from
8f33352 to
03b6d0d
Compare
graphite-app
bot
deleted the
winston/cnct-2497-unlink-auth-method-for-enclave-wallets
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2497/unlink-auth-method-for-enclave-wallets
PR-Codex overview
This PR introduces the ability to unlink accounts in the in-app wallet, enhancing user account management. It includes updates to types, functions, and UI components to support this new feature.
Detailed summary
UnlinkParamstype intypes.ts.unlinkProfilefunction in various connectors.unlinkProfile.useUnlinkProfilehook for React.