[SDK] Feature: Propagate error message from failed sign in #5621
+306
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 279cb6f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
greg/cnct-2545-bubble-up-auth-login-error-in-the-connect-ui
branch
from
0ad7141 to
cf21e6a
Compare
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5621 +/- ##
==========================================
+ Coverage 44.92% 45.89% +0.96%
==========================================
Files 1083 1083
Lines 56326 56333 +7
Branches 4061 4124 +63
==========================================
+ Hits 25306 25853 +547
+ Misses 30337 29788 -549
- Partials 683 692 +9
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
force-pushed
the
greg/cnct-2545-bubble-up-auth-login-error-in-the-connect-ui
branch
2 times, most recently
from
2bfc2ed to
b19f1b3
Compare
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on enhancing the user interface for error handling during the sign-in process in the `SignatureScreen` component of the `thirdweb` wallet. It propagates error messages to the UI, improving user feedback when sign-in fails.
### Detailed summary
- Updated `walletId` parameter to accept `Wallet` or `string` in `is-ecosystem-wallet.ts`.
- Changed state management in `SignatureScreen.tsx` to include an `error` state.
- Modified sign-in logic to set error messages on failure.
- Enhanced UI to display error messages and loading state.
- Added `data-testid` attributes for testing.
- Updated tests in `SignatureScreen.test.tsx` to cover new error handling scenarios and UI changes.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2545-bubble-up-auth-login-error-in-the-connect-ui
branch
from
b19f1b3 to
279cb6f
Compare
graphite-app
bot
deleted the
greg/cnct-2545-bubble-up-auth-login-error-in-the-connect-ui
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing the user experience during the sign-in process by propagating error messages to the UI and improving the handling of wallet connection states.
Detailed summary
is-ecosystem-wallet.tsto acceptWalletorstringas a parameter.SignatureScreen.tsxto manage error states and display error messages.data-testidattributes for testing purposes.SignatureScreen.test.tsxto cover various scenarios including error handling and wallet disconnection.