[SDK] Feature: Adds tsdoc parsing and other eslint rules #5622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5622 +/- ##
==========================================
+ Coverage 50.62% 50.63% +0.01%
==========================================
Files 1091 1091
Lines 57100 57100
Branches 4590 4589 -1
==========================================
+ Hits 28908 28914 +6
+ Misses 27478 27470 -8
- Partials 714 716 +2
*This pull request uses carry forward flags. Click here to find out more. |
gregfromstl
force-pushed
the
greg/cnct-2546-setup-ts-doc-linting
branch
from
c641ad2 to
1dc5ac9
Compare
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 5, 2024
gregfromstl
added
the
merge-queue
Contributor
Author
Merge activity
|
gregfromstl
added
the
hotfix
<!-- start pr-codex -->
## PR-Codex overview
This PR focuses on improving TypeScript typings, updating ESLint configurations, and refining package dependencies across various files in the `thirdweb` package.
### Detailed summary
- Changed parameter name from `uri` to `_uri` in `onDisplayUri` callback.
- Updated `WalletCreationOptions` type definition.
- Modified listener type to use `_event`.
- Added ESLint rules for better coding practices.
- Removed outdated TSDoc tags and added `@example` tag.
- Updated package dependencies in `pnpm-lock.yaml`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2546-setup-ts-doc-linting
branch
from
b15385f to
8234dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on updating type definitions, enhancing ESLint rules, and modifying package dependencies to improve code quality and maintainability.
Detailed summary
onDisplayUriparameter fromurito_uriintypes.ts.wallet-types.ts..eslintrc.cjsto provide better guidance on usage._event.tsdoc.json.package.jsonandpnpm-lock.yaml.