Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Dec 5, 2024

PR-Codex overview

This PR focuses on simplifying the form handling in the AirdropTab component by removing the unused formState and streamlining the logic for the disabled state of the submit button.

Detailed summary

  • Removed formState from the destructured return of useForm.
  • Updated the disabled prop of the submit button to only check if address is present and addresses length is zero, removing the dependency on formState.isDirty.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 5, 2024

@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 5:06am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 5, 2024 5:06am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 5:06am
wallet-ui ⬜️ Skipped (Inspect) Dec 5, 2024 5:06am

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 73e3a68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 04:26 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 04:26 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 04:26 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 5, 2024
Copy link
Contributor Author

kien-ngo commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo marked this pull request as ready for review December 5, 2024 04:27
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.92%. Comparing base (c893239) to head (73e3a68).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5623   +/-   ##
=======================================
  Coverage   44.92%   44.92%           
=======================================
  Files        1083     1083           
  Lines       56326    56326           
  Branches     4061     4061           
=======================================
  Hits        25306    25306           
  Misses      30337    30337           
  Partials      683      683           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c893239
packages 39.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.96 KB (0%) 960 ms (0%) 2.6 s (+11.67% 🔺) 3.6 s
thirdweb (cjs) 107.42 KB (0%) 2.2 s (0%) 6.2 s (+0.6% 🔺) 8.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 133 ms (-21.02% 🔽) 245 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 103 ms (+65.01% 🔺) 113 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 367 ms (0%) 374 ms (-31.19% 🔽) 740 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 04:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 04:57 Inactive
@graphite-app graphite-app bot merged commit 73e3a68 into main Dec 5, 2024
32 checks passed
@graphite-app graphite-app bot deleted the kien/dash-528 branch December 5, 2024 05:06
@vercel vercel bot temporarily deployed to Production – docs-v2 December 5, 2024 05:06 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 5, 2024 05:06 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 5, 2024 05:06 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants