-
Notifications
You must be signed in to change notification settings - Fork 619
[SDK] Add erc20Value to buyFromListing transaction #5630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 0aa2416 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
259151c to
f473fe6
Compare
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5630 +/- ##
==========================================
+ Coverage 47.82% 47.86% +0.03%
==========================================
Files 1088 1088
Lines 56661 56667 +6
Branches 4305 4314 +9
==========================================
+ Hits 27099 27122 +23
+ Misses 28864 28847 -17
Partials 698 698
*This pull request uses carry forward flags. Click here to find out more.
|
f473fe6 to
19a4860
Compare
19a4860 to
321dd4e
Compare
321dd4e to
52f3126
Compare
Merge activity
|
CNCT-2555 <!-- start pr-codex --> --- ## PR-Codex overview This PR introduces the `erc20Value` parameter to the `buyFromListing` transaction, enhancing the functionality for transactions involving ERC20 tokens. It also includes tests to ensure proper handling of ERC20 transactions in the marketplace. ### Detailed summary - Added `erc20Value` to `buyFromListing` to handle ERC20 transactions. - Implemented a test case for the new `erc20Value` functionality. - Deployed an ERC20 contract for testing purposes. - Verified the correct approval transaction is generated for ERC20 purchases. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
52f3126 to
0aa2416
Compare

CNCT-2555
PR-Codex overview
This PR adds an
erc20Valueproperty to thebuyFromListingtransaction, enabling proper handling of ERC20 currency in marketplace listings. It also includes tests to ensure the functionality works as expected with ERC20 tokens.Detailed summary
erc20ValuetobuyFromListingtransaction.erc20Valuebased on listing price and quantity.buyFromListingwith ERC20 currency.buyFromListing.