Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 5, 2024

fixes: DASH-542

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: c7a05c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 5, 2024 8:06pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 5, 2024 8:06pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 5, 2024 8:06pm
wallet-ui ⬜️ Skipped (Inspect) Dec 5, 2024 8:06pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 5, 2024 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 5, 2024 19:56 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 5, 2024 19:56 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Member Author

jnsdls commented Dec 5, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 5, 2024
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.89%. Comparing base (0f4dfd1) to head (c7a05c2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5632   +/-   ##
=======================================
  Coverage   45.89%   45.89%           
=======================================
  Files        1083     1083           
  Lines       56333    56333           
  Branches     4123     4123           
=======================================
  Hits        25853    25853           
  Misses      29788    29788           
  Partials      692      692           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0f4dfd1
packages 41.15% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@linear
Copy link

linear bot commented Dec 5, 2024

@jnsdls jnsdls marked this pull request as ready for review December 5, 2024 19:58
@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 47.96 KB (0%) 960 ms (0%) 3.7 s (-14.1% 🔽) 4.6 s
thirdweb (cjs) 107.42 KB (0%) 2.2 s (0%) 5.8 s (-15.12% 🔽) 8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 110 ms (-8.31% 🔽) 221 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 39 ms (-8.95% 🔽) 49 ms
thirdweb/react (minimal + tree-shaking) 18.3 KB (0%) 367 ms (0%) 455 ms (-20.02% 🔽) 821 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants