Skip to content

fixes: DASH-541 #5636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2024
Merged

fixes: DASH-541 #5636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 0 additions & 29 deletions apps/dashboard/src/app/(dashboard)/profile/[addressOrEns]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,42 +44,13 @@ export async function generateMetadata(props: PageProps): Promise<Metadata> {
return notFound();
}

const publisherProfile = await fetchPublisherProfile(
resolvedInfo.address,
).catch(() => null);

if (!publisherProfile) {
return notFound();
}

const displayName = shortenIfAddress(
resolvedInfo.ensName || resolvedInfo.address,
).replace("deployer.thirdweb.eth", "thirdweb.eth");

// TODO - move this to opengraph-image.tsx
// this is not working even on prod
// const ogImageLink = ProfileOG.toUrl({
// displayName,
// bio: publisherProfile.bio,
// avatar: publisherProfile.avatar,
// });

return {
title: displayName,
description: `Visit ${displayName}'s profile. See their published contracts and deploy them in one click.`,
// openGraph: {
// title: displayName,
// images: ogImageLink
// ? [
// {
// url: ogImageLink.toString(),
// alt: `${displayName}'s profile on thirdweb.com`,
// width: 1200,
// height: 630,
// },
// ]
// : undefined,
// },
};
}

Expand Down
7 changes: 7 additions & 0 deletions apps/dashboard/src/components/contract-components/publisher/masked-avatar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,13 @@ export const PublisherAvatar: React.FC<PublisherAvatarProps> = ({
client,
});

if (
!(isPending || ensQuery.isPending || publisherProfile.isPending) &&
!publisherImageUrl
) {
return null;
}

return (
<MaskedAvatar
isPending={isPending || ensQuery.isPending || publisherProfile.isPending}
Expand Down
Loading