fix: client analytics for ecosystem wallet #5643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElasticBottle
requested review from
MananTank,
jakubkrehel,
jnsdls and
joaquim-verges
as code owners
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
=======================================
Coverage 48.16% 48.16%
=======================================
Files 1089 1089
Lines 56875 56875
Branches 4361 4361
=======================================
Hits 27395 27395
Misses 28780 28780
Partials 700 700
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
gregfromstl
approved these changes
Dec 6, 2024
ElasticBottle
added
the
merge-queue
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Dec 6, 2024
https://linear.app/thirdweb/issue/CNCT-2526/analytics-discrepancy-after-migration-to-ecosystem-wallets This fixes for all queries from Nov onwards. We have to think of a solution to backfill for data stretching before Nov if customers ask for it <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the handling of ecosystem identifiers in the codebase, changing from using `ecosystemId` to `ecosystemSlug` for better clarity and consistency across various components and functions. ### Detailed summary - Changed prop from `ecosystemId` to `ecosystemSlug` in `EcosystemAnalyticsPage`. - Updated `getEcosystemWalletUsage` calls to use `ecosystemSlug` instead of `ecosystemId` in `EcosystemSlugLayout` and `EcosystemAnalyticsPage`. - Adjusted the parameter type in `EcosystemAnalyticsPage` and `getEcosystemWalletUsage` to reflect the new `ecosystemSlug` usage. - Modified the fetch URL in `getEcosystemWalletUsage` to use `ecosystemSlug` for API requests. - Updated error message in `getEcosystemWalletUsage` to specify "ecosystem wallet stats". > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
ElasticBottle
force-pushed
the
winston/cnct-2526-analytics-discrepancy-after-migration-to-ecosystem-wallets
branch
from
782c65c to
87b54c9
Compare
graphite-app
bot
deleted the
winston/cnct-2526-analytics-discrepancy-after-migration-to-ecosystem-wallets
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/thirdweb/issue/CNCT-2526/analytics-discrepancy-after-migration-to-ecosystem-wallets
This fixes for all queries from Nov onwards.
We have to think of a solution to backfill for data stretching before Nov if customers ask for it
PR-Codex overview
This PR focuses on changing the parameter used to identify ecosystems from
ecosystemIdtoecosystemSlugacross various components and functions, enhancing clarity and consistency in the codebase.Detailed summary
EcosystemAnalyticsPageto useecosystemSluginstead ofecosystemId.getEcosystemWalletUsageinEcosystemSlugLayoutto useecosystemSlug.EcosystemAnalyticsPagefunction signature fromecosystemIdtoecosystemSlug.getEcosystemWalletUsagefunction to acceptecosystemSluginstead ofecosystemId.getEcosystemWalletUsageto reflect the change toecosystemSlug.