Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 6, 2024

closes: DASH-556


PR-Codex overview

This PR focuses on the removal of several files related to RPC validation and chain validation functionality from the dashboard application.

Detailed summary

  • Deleted the file useRpcValidation.ts, which likely contained hooks for validating RPC calls.
  • Removed the page component page.tsx, which was probably responsible for rendering the chain validation page.
  • Deleted the component ChainValidation.tsx, which was likely used for validating chains in the dashboard.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: e92d960

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 07:10 Inactive
@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 6:59pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 6, 2024 6:59pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 6, 2024 6:59pm
wallet-ui ⬜️ Skipped (Inspect) Dec 6, 2024 6:59pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 07:10 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 07:10 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 6, 2024
@jnsdls jnsdls marked this pull request as ready for review December 6, 2024 07:10
Copy link
Member Author

jnsdls commented Dec 6, 2024

@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.86%. Comparing base (b30a814) to head (e92d960).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5645   +/-   ##
=======================================
  Coverage   47.86%   47.86%           
=======================================
  Files        1088     1088           
  Lines       56667    56667           
  Branches     4314     4314           
=======================================
  Hits        27122    27122           
  Misses      28847    28847           
  Partials      698      698           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from b30a814
packages 43.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.72 KB (0%) 915 ms (0%) 2.1 s (+17.09% 🔺) 3 s
thirdweb (cjs) 106.26 KB (0%) 2.2 s (0%) 4.2 s (-15.64% 🔽) 6.3 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 105 ms (-42.75% 🔽) 217 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 47 ms (+13.68% 🔺) 57 ms
thirdweb/react (minimal + tree-shaking) 18.74 KB (0%) 375 ms (0%) 514 ms (-57.71% 🔽) 889 ms

@linear
Copy link

linear bot commented Dec 6, 2024

@jnsdls jnsdls force-pushed the 12-05-remove_unused_internal_tool branch from 9b4f195 to 8d0e7ac Compare December 6, 2024 18:36
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 18:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 18:36 Inactive
@jnsdls jnsdls force-pushed the 12-05-remove_unused_internal_tool branch from 8d0e7ac to 7691a16 Compare December 6, 2024 18:46
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 18:46 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 18:46 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Merge activity

closes: DASH-556

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on removing files related to RPC validation within the dashboard application, indicating a potential refactor or removal of unnecessary functionality.

### Detailed summary
- Deleted the file `apps/dashboard/src/hooks/chains/useRpcValidation.ts`
- Removed the file `apps/dashboard/src/app/(dashboard)/chain/validate/page.tsx`
- Eliminated the file `apps/dashboard/src/app/(dashboard)/chain/validate/ChainValidation.tsx`

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants