remove a bunch of <Flex> #5646
Merged
remove a bunch of <Flex> #5646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
jnsdls
requested review from
MananTank,
jakubkrehel and
joaquim-verges
as code owners
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
...p/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/airdrop-tab.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5646 +/- ##
=======================================
Coverage 47.86% 47.86%
=======================================
Files 1088 1088
Lines 56667 56667
Branches 4314 4314
=======================================
Hits 27122 27122
Misses 28847 28847
Partials 698 698
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
joaquim-verges
approved these changes
Dec 6, 2024
...[team_slug]/(team)/~/engine/(instance)/[engineId]/metrics/components/EngineSystemMetrics.tsx
Outdated
Show resolved
Hide resolved
...p/(dashboard)/(chain)/[chain_id]/[contractAddress]/nfts/[tokenId]/components/airdrop-tab.tsx
Outdated
Show resolved
Hide resolved
jnsdls
force-pushed
the
12-05-remove_unused_internal_tool
branch
from
9b4f195 to
8d0e7ac
Compare
jnsdls
force-pushed
the
12-05-remove_a_bunch_of_flex_
branch
from
73be5f7 to
4e2dc1d
Compare
jnsdls
force-pushed
the
12-05-remove_a_bunch_of_flex_
branch
from
606b312 to
f29deaa
Compare
jnsdls
changed the base branch from
12-05-remove_unused_internal_tool
to
graphite-base/5646
jnsdls
force-pushed
the
12-05-remove_a_bunch_of_flex_
branch
from
f29deaa to
9137cff
Compare
jnsdls
force-pushed
the
graphite-base/5646
branch
from
7691a16 to
e92d960
Compare
jnsdls
force-pushed
the
12-05-remove_a_bunch_of_flex_
branch
from
9137cff to
4ae376c
Compare
Contributor
Merge activity
|
closes: DASH-557 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the layout of various components in the application from using `Flex` elements to using `div` elements with Tailwind CSS classes for styling, improving consistency and readability. ### Detailed summary - Changed `Flex` components to `div` with Tailwind CSS classes in `nft-property.tsx`. - Updated layout in `external-links-fieldset.tsx` to use `fieldset` and `div`. - Modified `engine-wallet-config.tsx` to replace `Flex` with `div`. - Refactored `engine-relayer.tsx` to use `div` instead of `Flex`. - Updated `ContractTokensPage.tsx` to use `div` for layout. - Changed `ContractExplorerPage.tsx` layout from `Flex` to `div`. - Refactored `proposal.tsx` to replace `Flex` with `div`. - Updated `EngineSystemMetrics.tsx` to use `div` instead of `Flex`. - Changed layout in `airdrop-tab.tsx` to replace `Flex` with `div`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-05-remove_a_bunch_of_flex_
branch
from
4ae376c to
a9c30e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: DASH-557
PR-Codex overview
This PR focuses on refactoring components in a React application to replace the usage of
Flexfrom@chakra-ui/reactwithdivelements styled using Tailwind CSS classes, enhancing consistency in styling.Detailed summary
<Flex>with<div>and applied Tailwind CSS classes in multiple components.classNamefor layout adjustments innft-property.tsx,external-links-fieldset.tsx,engine-wallet-config.tsx,engine-relayer.tsx,ContractTokensPage.tsx,ContractExplorerPage.tsx,proposal.tsx, and others.