Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 6, 2024

closes: DASH-558, DASH-559


PR-Codex overview

This PR primarily focuses on updating the privacy and terms of service URLs across the application, along with removing several unused files related to the dashboard's mission and legal pages.

Detailed summary

  • Deleted multiple unused files: tos.tsx, mission.tsx, privacy.tsx, and various mission component files.
  • Updated footer links to point to /privacy-policy and /terms.
  • Adjusted LoginPage to use /privacy-policy and /terms URLs.
  • Added redirects for /tos to /terms, /privacy to /privacy-policy, and /mission to /home.
  • Changed external links in app-footer.tsx to /privacy-policy and /terms.
  • Updated connect-wallet component to use new URLs for privacy and terms.
  • Removed references to mission and tos from page-id.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2024

⚠️ No Changeset found

Latest commit: 406c885

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 8:14pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 6, 2024 8:14pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 6, 2024 8:14pm
wallet-ui ⬜️ Skipped (Inspect) Dec 6, 2024 8:14pm

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 18:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 18:42 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 6, 2024
Copy link
Member Author

jnsdls commented Dec 6, 2024

@jnsdls jnsdls mentioned this pull request Dec 6, 2024
@codecov
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.86%. Comparing base (a9c30e9) to head (406c885).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5647   +/-   ##
=======================================
  Coverage   47.86%   47.86%           
=======================================
  Files        1088     1088           
  Lines       56667    56667           
  Branches     4314     4314           
=======================================
  Hits        27122    27122           
  Misses      28847    28847           
  Partials      698      698           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a9c30e9
packages 43.62% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@linear
Copy link

linear bot commented Dec 6, 2024

@jnsdls jnsdls marked this pull request as ready for review December 6, 2024 18:45
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 45.72 KB (0%) 915 ms (0%) 2.1 s (-27.5% 🔽) 3 s
thirdweb (cjs) 106.26 KB (0%) 2.2 s (0%) 5.7 s (-7.53% 🔽) 7.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 310 ms (+67.1% 🔺) 421 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 42 ms (-0.41% 🔽) 52 ms
thirdweb/react (minimal + tree-shaking) 18.74 KB (0%) 375 ms (0%) 349 ms (-21.2% 🔽) 724 ms

@jnsdls jnsdls force-pushed the 12-05-remove_a_bunch_of_flex_ branch from 606b312 to f29deaa Compare December 6, 2024 18:46
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from db9012a to f8d9093 Compare December 6, 2024 18:46
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 18:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 18:47 Inactive
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from f8d9093 to af7a72f Compare December 6, 2024 18:53
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 18:53 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 18:53 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 18:53 Inactive
@jnsdls jnsdls force-pushed the 12-05-remove_a_bunch_of_flex_ branch 2 times, most recently from 9137cff to 4ae376c Compare December 6, 2024 19:00
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from af7a72f to 05ba50b Compare December 6, 2024 19:00
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 19:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 19:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 19:00 Inactive
@jnsdls jnsdls changed the base branch from 12-05-remove_a_bunch_of_flex_ to graphite-base/5647 December 6, 2024 19:08
@jnsdls jnsdls force-pushed the graphite-base/5647 branch from 4ae376c to a9c30e9 Compare December 6, 2024 19:14
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from 05ba50b to fe3e195 Compare December 6, 2024 19:14
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 19:14 Inactive
@jnsdls jnsdls changed the base branch from graphite-base/5647 to main December 6, 2024 19:14
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from fe3e195 to 315cd00 Compare December 6, 2024 19:14
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 19:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 19:14 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Merge activity

closes: DASH-558, DASH-559

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on the removal of outdated pages and components related to terms of service and privacy policy, while also updating links and redirects to reflect new URLs.

### Detailed summary
- Deleted several files: `tos.tsx`, `mission.tsx`, `privacy.tsx`, and multiple component files.
- Updated links in `footerLinks.tsx` for "Privacy Policy" and "Terms of Service".
- Changed URLs in `LoginPage.tsx` and `connect-wallet/index.tsx` for privacy and terms.
- Added redirects in `redirects.js` for `/tos` to `/terms`, `/privacy` to `/privacy-policy`, and `/mission` to `/home`.
- Removed references to `Mission` and legacy pages in `page-id.ts`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch from 315cd00 to 406c885 Compare December 6, 2024 20:11
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 6, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 6, 2024 20:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 6, 2024 20:11 Inactive
@graphite-app graphite-app bot merged commit 406c885 into main Dec 6, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-06-move__terms__privacy-policy_to_framer_remove__mission branch December 6, 2024 20:15
@vercel vercel bot temporarily deployed to Production – docs-v2 December 6, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 6, 2024 20:15 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 6, 2024 20:15 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants