Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 7, 2024

fixes: DASH-563


PR-Codex overview

This PR focuses on improving the PublisherHeader component by handling loading states more gracefully through the use of a placeholder address.

Detailed summary

  • Added import for ZERO_ADDRESS from thirdweb.
  • Modified the address prop of AccountProvider to use ZERO_ADDRESS during loading, preventing the component from crashing when the actual address is not yet available.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 7, 2024

⚠️ No Changeset found

Latest commit: 37aa163

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2024 2:23am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 7, 2024 2:23am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 7, 2024 2:23am
wallet-ui ⬜️ Skipped (Inspect) Dec 7, 2024 2:23am

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 7, 2024 02:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 7, 2024 02:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 7, 2024 02:09 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 7, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 7, 2024
Copy link
Member Author

jnsdls commented Dec 7, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 7, 2024

@jnsdls jnsdls marked this pull request as ready for review December 7, 2024 02:09
@codecov
Copy link

codecov bot commented Dec 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.97%. Comparing base (c48e0c9) to head (37aa163).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5651   +/-   ##
=======================================
  Coverage   48.97%   48.97%           
=======================================
  Files        1089     1089           
  Lines       56891    56891           
  Branches     4440     4440           
=======================================
  Hits        27861    27861           
  Misses      28325    28325           
  Partials      705      705           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from c48e0c9
packages 45.02% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.09 KB (-0.09% 🔽) 822 ms (-0.09% 🔽) 1.4 s (-21.47% 🔽) 2.2 s
thirdweb (cjs) 104.48 KB (0%) 2.1 s (0%) 2.2 s (-8.19% 🔽) 4.3 s
thirdweb (minimal + tree-shaking) 4.37 KB (0%) 88 ms (0%) 163 ms (+33.55% 🔺) 251 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 51 ms (-9.56% 🔽) 61 ms
thirdweb/react (minimal + tree-shaking) 16.99 KB (+0.03% 🔺) 340 ms (+0.03% 🔺) 665 ms (+13.57% 🔺) 1.1 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 7, 2024

Merge activity

@jnsdls jnsdls force-pushed the add_zero_address_fallback_for_publisher_header branch from 02b3a1d to 37aa163 Compare December 7, 2024 02:19
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 7, 2024 02:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 7, 2024 02:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 7, 2024 02:20 Inactive
@graphite-app graphite-app bot merged commit 37aa163 into main Dec 7, 2024
31 checks passed
@graphite-app graphite-app bot deleted the add_zero_address_fallback_for_publisher_header branch December 7, 2024 02:23
@vercel vercel bot temporarily deployed to Production – docs-v2 December 7, 2024 02:23 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 7, 2024 02:23 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 7, 2024 02:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants