-
Notifications
You must be signed in to change notification settings - Fork 619
add zero address fallback for publisher header #5651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add zero address fallback for publisher header #5651
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5651 +/- ##
=======================================
Coverage 48.97% 48.97%
=======================================
Files 1089 1089
Lines 56891 56891
Branches 4440 4440
=======================================
Hits 27861 27861
Misses 28325 28325
Partials 705 705
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
Merge activity
|
02b3a1d to
37aa163
Compare

fixes: DASH-563
PR-Codex overview
This PR focuses on improving the
PublisherHeadercomponent by handling loading states more gracefully through the use of a placeholder address.Detailed summary
ZERO_ADDRESSfromthirdweb.addressprop ofAccountProviderto useZERO_ADDRESSduring loading, preventing the component from crashing when the actual address is not yet available.