Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 8, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on enhancing error messages for various wallet operations and updating test cases for the smart-wallet functionality. It also modifies the chain definition used in tests and adjusts the test descriptions.

Detailed summary

  • Improved error messages in:
    • sign-message.enclave.ts
    • generate-wallet.enclave.ts
    • sign-typed-data.enclave.ts
    • sign-transaction.enclave.ts
    • userop.ts
  • Updated chain definition from defineChain to arbitrumSepolia in smart-wallet-dev.test.ts.
  • Changed test descriptions in smart-wallet-dev.test.ts.
  • Adjusted assertions in the message signing test to check for signature length.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:57pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:57pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:57pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 8, 2024 8:57pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 8, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 8, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges marked this pull request as ready for review December 8, 2024 20:06
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.13 KB (0%) 823 ms (0%) 274 ms (+49.23% 🔺) 1.1 s
thirdweb (cjs) 104.48 KB (0%) 2.1 s (0%) 257 ms (-22.53% 🔽) 2.4 s
thirdweb (minimal + tree-shaking) 4.37 KB (0%) 88 ms (0%) 11 ms (-7.38% 🔽) 99 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 6 ms (-12.84% 🔽) 16 ms
thirdweb/react (minimal + tree-shaking) 16.99 KB (0%) 340 ms (0%) 51 ms (-35.35% 🔽) 391 ms

@joaquim-verges joaquim-verges force-pushed the fix_Improve_enclave_and_userop_error_messages branch from 104c6a6 to 9f42ee0 Compare December 8, 2024 20:49
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: 9f42ee0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 50.62%. Comparing base (015293e) to head (9f42ee0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/thirdweb/src/wallets/smart/lib/userop.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5653      +/-   ##
==========================================
- Coverage   50.63%   50.62%   -0.01%     
==========================================
  Files        1091     1092       +1     
  Lines       57100    57130      +30     
  Branches     4589     4593       +4     
==========================================
+ Hits        28914    28924      +10     
- Misses      27470    27490      +20     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 015293e
packages 47.08% <0.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
packages/thirdweb/src/wallets/smart/lib/userop.ts 66.54% <0.00%> (-0.25%) ⬇️

... and 4 files with indirect coverage changes

@gregfromstl gregfromstl changed the title fix: Improve enclave and userop error messages [SDK] Fix: Improve enclave and userop error messages Dec 9, 2024
@joaquim-verges joaquim-verges merged commit df734ba into main Dec 9, 2024
30 of 33 checks passed
@joaquim-verges joaquim-verges deleted the fix_Improve_enclave_and_userop_error_messages branch December 9, 2024 09:08
@jnsdls jnsdls mentioned this pull request Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants