Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 9, 2024

Fixes: DASH-564 and DASH-494


PR-Codex overview

This PR focuses on changing the UI text from "Sign In" to "Connect Wallet" across various components in the dashboard application, enhancing clarity for users regarding wallet connection actions. Additionally, it updates account retrieval methods and logic in several components.

Detailed summary

  • Updated button text from Sign In to Connect Wallet in multiple components:
    • MismatchButton
    • FaucetButton
    • TeamHeaderLoggedOut
    • TeamHeaderLoggedOutMobileUI
  • Changed account retrieval from getAuthToken to getRawAccount in TeamHeader.
  • Modified logic in TeamLayout to fetch account details using getValidAccount.
  • Updated LoginPage to ensure redirects are handled correctly based on account status.
  • Adjusted props in TeamHeaderLoggedIn to pass account information directly.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 16:14 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: 3268af6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 16:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 16:14 Inactive
@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 7:12pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 9, 2024 7:12pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 9, 2024 7:12pm
wallet-ui ⬜️ Skipped (Inspect) Dec 9, 2024 7:12pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 9, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear
Copy link

linear bot commented Dec 9, 2024

@MananTank MananTank marked this pull request as ready for review December 9, 2024 16:14
@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.72%. Comparing base (4ced3d2) to head (3268af6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5658   +/-   ##
=======================================
  Coverage   50.72%   50.72%           
=======================================
  Files        1092     1092           
  Lines       57213    57213           
  Branches     4630     4630           
=======================================
  Hits        29019    29019           
  Misses      27478    27478           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 4ced3d2
packages 47.20% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.13 KB (0%) 823 ms (0%) 942 ms (+17.25% 🔺) 1.8 s
thirdweb (cjs) 104.48 KB (0%) 2.1 s (0%) 2.4 s (+8.96% 🔺) 4.5 s
thirdweb (minimal + tree-shaking) 4.37 KB (0%) 88 ms (0%) 118 ms (-30.04% 🔽) 206 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 55 ms (+25.29% 🔺) 65 ms
thirdweb/react (minimal + tree-shaking) 16.99 KB (0%) 340 ms (0%) 287 ms (+24% 🔺) 627 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank MananTank force-pushed the 12-09-_dashboard_login_flow_improvements branch from 2124905 to 4e8de10 Compare December 9, 2024 16:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 16:19 Inactive
@MananTank MananTank force-pushed the 12-09-_dashboard_login_flow_improvements branch from 4e8de10 to 76bdc9f Compare December 9, 2024 19:00
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 19:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 19:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 19:00 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Merge activity

Fixes: DASH-564 and DASH-494

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on updating the user interface and functionality related to wallet connection across various components in the dashboard, primarily changing instances of "Sign In" to "Connect Wallet" and modifying how account information is handled.

### Detailed summary
- Changed button text from `Sign In` to `Connect Wallet` in multiple components.
- Updated `TeamHeader` to use `getRawAccount` instead of `getAuthToken`.
- Modified account handling in `TeamLayout` functions to include `getValidAccount`.
- Adjusted `LoginPage` logic for account onboarding and redirection.
- Enhanced `TeamHeaderLoggedIn` to accept `account` as a prop directly.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-09-_dashboard_login_flow_improvements branch from 76bdc9f to 3268af6 Compare December 9, 2024 19:08
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 19:08 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 19:08 Inactive
@graphite-app graphite-app bot merged commit 3268af6 into main Dec 9, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-09-_dashboard_login_flow_improvements branch December 9, 2024 19:12
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 9, 2024 19:12 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 9, 2024 19:12 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 9, 2024 19:12 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants