Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 9, 2024

DASH-471


PR-Codex overview

This PR focuses on refactoring the DeployedContractsPage and related components, improving layout structure, and enhancing the user interface for contract management across various account and team pages.

Detailed summary

  • Removed className prop from DeployedContractsPage.
  • Updated layout to use SidebarLayout in contracts/layout.tsx.
  • Added authentication checks in new Page components.
  • Enhanced PublishedContractsPage with loading states and links.
  • Adjusted header titles and descriptions for clarity.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 9:25pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 9, 2024 9:25pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 9, 2024 9:25pm
wallet-ui ⬜️ Skipped (Inspect) Dec 9, 2024 9:25pm

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 9, 2024
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank changed the title Add published contracts page in teams, account and project layout [Dashboard] Add published contracts page in teams, account and project layout Dec 9, 2024
@MananTank MananTank changed the title [Dashboard] Add published contracts page in teams, account and project layout [Dashboard] Add published contracts page in teams, account and project layouts Dec 9, 2024
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

⚠️ No Changeset found

Latest commit: a41e423

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MananTank MananTank marked this pull request as ready for review December 9, 2024 19:34
@MananTank MananTank force-pushed the 12-10-add_published_contracts_page_in_teams_account_and_project_layout branch from 9bf2dc9 to 9bede6d Compare December 9, 2024 19:36
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 19:36 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 19:36 Inactive
@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.72%. Comparing base (2d66242) to head (a41e423).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5659   +/-   ##
=======================================
  Coverage   50.72%   50.72%           
=======================================
  Files        1092     1092           
  Lines       57213    57213           
  Branches     4630     4630           
=======================================
  Hits        29019    29019           
  Misses      27478    27478           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2d66242
packages 47.20% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@MananTank MananTank force-pushed the 12-10-add_published_contracts_page_in_teams_account_and_project_layout branch from 9bede6d to 21a3a9d Compare December 9, 2024 19:38
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 19:38 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 19:38 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 19:38 Inactive
@MananTank MananTank force-pushed the 12-10-add_published_contracts_page_in_teams_account_and_project_layout branch from 21a3a9d to 8c9bee9 Compare December 9, 2024 19:38
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 19:38 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 19:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 19:39 Inactive
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.13 KB (0%) 823 ms (0%) 837 ms (-18.25% 🔽) 1.7 s
thirdweb (cjs) 104.48 KB (0%) 2.1 s (0%) 3.1 s (+20.51% 🔺) 5.2 s
thirdweb (minimal + tree-shaking) 4.37 KB (0%) 88 ms (0%) 106 ms (-9.64% 🔽) 193 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 63 ms (-46.06% 🔽) 73 ms
thirdweb/react (minimal + tree-shaking) 16.99 KB (0%) 340 ms (0%) 1.2 s (+107.35% 🔺) 1.5 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Merge activity

…t layouts (#5659)

DASH-471

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on refactoring components related to contracts in the dashboard, enhancing the layout with `SidebarLayout`, and improving the user interface for contract management with better structure and loading states.

### Detailed summary
- Updated `layout.tsx` to use `SidebarLayout` for contracts.
- Simplified return statements in `DeployedContractsPage` components.
- Changed class names for better styling consistency.
- Added authentication checks in published contract pages.
- Created `PublishedContractsPage` to display published contracts with loading states.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@MananTank MananTank force-pushed the 12-10-add_published_contracts_page_in_teams_account_and_project_layout branch from 8c9bee9 to a41e423 Compare December 9, 2024 21:19
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 9, 2024 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 9, 2024 21:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 9, 2024 21:19 Inactive
@graphite-app graphite-app bot merged commit a41e423 into main Dec 9, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-10-add_published_contracts_page_in_teams_account_and_project_layout branch December 9, 2024 21:26
@vercel vercel bot temporarily deployed to Production – wallet-ui December 9, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 9, 2024 21:26 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 9, 2024 21:26 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants