Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 9, 2024

Problem solved

CNCT-2598


PR-Codex overview

This PR introduces support for signature minting in LoyaltyCard contracts by adding new functions and event definitions, enhancing the mintWithSignature functionality, and updating relevant tests and types to accommodate the new structure.

Detailed summary

  • Added support for signature minting in LoyaltyCard contracts.
  • Introduced mintWithSignature function with updated parameters.
  • Created TokensMintedWithSignature event for tracking minting.
  • Updated generateMintSignature to handle LoyaltyCard type.
  • Enhanced test cases for minting NFTs with signatures.
  • Defined new payload structures for the updated minting process.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:57am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:57am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:57am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 10, 2024 1:57am

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2024

🦋 Changeset detected

Latest commit: 086f157

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 9, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 9, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 9, 2024 23:44
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codecov
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 98.48485% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.82%. Comparing base (e702490) to head (086f157).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...es/thirdweb/src/extensions/erc721/write/sigMint.ts 98.48% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5671      +/-   ##
==========================================
+ Coverage   50.71%   50.82%   +0.11%     
==========================================
  Files        1092     1092              
  Lines       57209    57334     +125     
  Branches     4629     4636       +7     
==========================================
+ Hits        29015    29142     +127     
+ Misses      27478    27476       -2     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from e702490
packages 47.34% <98.48%> (+0.14%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...es/thirdweb/src/extensions/erc721/write/sigMint.ts 96.41% <98.48%> (+1.96%) ⬆️

... and 1 file with indirect coverage changes

@joaquim-verges joaquim-verges force-pushed the feat_Add_LoyaltyCard_contract_type_support_for_ERC721_signature_minting branch from 8e365f6 to 8214da9 Compare December 10, 2024 01:33
@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 2.7 s (+4.52% 🔺) 3.6 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 8 s (+17.82% 🔺) 10.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 237 ms (-40.62% 🔽) 349 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 74 ms (-23.36% 🔽) 84 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 517 ms (+11.67% 🔺) 897 ms

@joaquim-verges joaquim-verges force-pushed the feat_Add_LoyaltyCard_contract_type_support_for_ERC721_signature_minting branch from 8214da9 to 086f157 Compare December 10, 2024 01:47
@joaquim-verges joaquim-verges merged commit dcd5822 into main Dec 10, 2024
30 of 32 checks passed
@joaquim-verges joaquim-verges deleted the feat_Add_LoyaltyCard_contract_type_support_for_ERC721_signature_minting branch December 10, 2024 01:52
@jnsdls jnsdls mentioned this pull request Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants