-
Notifications
You must be signed in to change notification settings - Fork 620
feat: Add LoyaltyCard contract type support for ERC721 signature minting #5671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LoyaltyCard contract type support for ERC721 signature minting #5671
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 086f157 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5671 +/- ##
==========================================
+ Coverage 50.71% 50.82% +0.11%
==========================================
Files 1092 1092
Lines 57209 57334 +125
Branches 4629 4636 +7
==========================================
+ Hits 29015 29142 +127
+ Misses 27478 27476 -2
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
8e365f6 to
8214da9
Compare
packages/thirdweb/src/extensions/erc721/__generated__/ISignatureMintERC721_v2/read/verify.ts
Show resolved
Hide resolved
size-limit report 📦
|
8214da9 to
086f157
Compare

Problem solved
CNCT-2598
PR-Codex overview
This PR introduces support for signature minting in
LoyaltyCardcontracts by adding new functions and event definitions, enhancing themintWithSignaturefunctionality, and updating relevant tests and types to accommodate the new structure.Detailed summary
LoyaltyCardcontracts.mintWithSignaturefunction with updated parameters.TokensMintedWithSignatureevent for tracking minting.generateMintSignatureto handleLoyaltyCardtype.