fix: ox is hard dependency #5672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3b53732 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
gregfromstl
force-pushed
the
greg/fix-ox-dep
branch
from
76aae21 to
6f7a31b
Compare
gregfromstl
added
the
hotfix
Contributor
Author
Merge activity
|
joaquim-verges
approved these changes
Dec 10, 2024
gregfromstl
added
the
merge-queue
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5672 +/- ##
==========================================
- Coverage 50.72% 50.71% -0.01%
==========================================
Files 1092 1092
Lines 57209 57209
Branches 4629 4629
==========================================
- Hits 29020 29015 -5
- Misses 27473 27478 +5
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more. |
CNCT-1111 ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on updating the `thirdweb` package's `package.json` file to fix the version of `ox` to `0.4.0` while retaining other configurations and dependencies. ### Detailed summary - Updated `ox` version to `0.4.0` in `peerDependencies`. - Maintained all other existing fields and dependencies in `package.json`. - No structural changes to the `thirdweb` package configuration. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/fix-ox-dep
branch
from
6f7a31b to
3b53732
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-1111
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating the
thirdwebpackage's metadata and dependencies, specifically addressing the versioning of theoxdependency.Detailed summary
oxdependency to version0.4.0.thirdwebpackage metadata includingname,version,repository, andauthor.exports,typesVersions,dependencies, anddevDependencies.