[SDK] Add missing use-client directives to some components #5676
+13
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
MananTank,
edwardysun,
gregfromstl,
jnsdls and
joaquim-verges
as code owners
Contributor
size-limit report 📦
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5676 +/- ##
==========================================
- Coverage 51.27% 51.27% -0.01%
==========================================
Files 1092 1092
Lines 57346 57346
Branches 4686 4685 -1
==========================================
- Hits 29406 29404 -2
- Misses 27224 27226 +2
Partials 716 716
*This pull request uses carry forward flags. Click here to find out more.
|
MananTank
approved these changes
Dec 10, 2024
Contributor
Merge activity
|
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR focuses on updating various components in the `thirdweb` package, specifically related to `Account`, `NFT`, `Chain`, and `Token` functionalities. It introduces new imports and ensures that the components are utilizing the necessary contexts and types.
### Detailed summary
- In `Account/provider.tsx`: Added import for `Address`.
- In `NFT/provider.tsx`: Added import for `ThirdwebContract`.
- In `Account/blobbie.tsx`: Imported `Blobbie` and `useAccountContext`.
- In `Chain/icon.tsx`, `Token/icon.tsx`, `NFT/name.tsx`, and `NFT/media.tsx`: Imported `UseQueryOptions`, `useQuery`, and `getChainMetadata`.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kien-ngo
force-pushed
the
kien/cnct-2624
branch
from
260714b to
a9dd26c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on organizing and refining the context and components related to
Account,NFT, andTokenfunctionalities in thethirdwebpackage.Detailed summary
useAccountContextimport inAccount/blobbie.tsx.ThirdwebContracttype inNFT/provider.tsx,NFT/name.tsx, andNFT/media.tsx.useQueryandgetChainMetadataimports acrossChain/icon.tsx,Token/icon.tsx, andNFT/name.tsx.