Skip to content

Conversation

@iuwqyir
Copy link
Contributor

@iuwqyir iuwqyir commented Dec 10, 2024

Problem solved

https://linear.app/thirdweb/issue/INSIGHT-480/improvements-required-for-insight-playground

Updated the authentication method in the Insight API documentation to use the x-client-id header instead of embedding the client ID in the URL path.


PR-Codex overview

This PR updates the configuration for issue prefixes and enhances the documentation for the insight API usage, including a new authentication method.

Detailed summary

  • Updated VALID_ISSUE_PREFIXES to include INSIGHT.
  • Corrected the formatting of "client ID" in the Markdown file.
  • Added a note on using the client ID in the x-client-id header or clientId query parameter.
  • Modified the fetch request in the getUsdtTransfers function to include headers for authentication.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 3f56252

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 10, 2024 21:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 21:54 Inactive
@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:58am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:58am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:58am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 0:58am

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 10, 2024 21:54 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 10, 2024
Copy link
Contributor Author

iuwqyir commented Dec 10, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@iuwqyir iuwqyir marked this pull request as ready for review December 10, 2024 21:55
@iuwqyir iuwqyir requested a review from a team as a code owner December 10, 2024 21:55
@iuwqyir iuwqyir requested a review from a team December 10, 2024 21:55
@iuwqyir iuwqyir requested a review from a team as a code owner December 10, 2024 21:55
@iuwqyir iuwqyir force-pushed the 12-10-change_insight_auth_in_docs branch from 79eb0fb to 7fdc5be Compare December 10, 2024 21:55
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 10, 2024 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 10, 2024 21:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 10, 2024 21:55 Inactive
const response = await fetch('https://1.insight.thirdweb.com/v1/<client-id>/events/0xdAC17F958D2ee523a2206206994597C13D831ec7/Transfer(address,address,uint256)?limit=5');
const response = await fetch('https://1.insight.thirdweb.com/v1/events/0xdAC17F958D2ee523a2206206994597C13D831ec7/Transfer(address,address,uint256)?limit=5', {
headers: {
'x-client-id': <YOUR_THIRDWEB_CLIENT_ID>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The x-client-id header value needs to be a string literal. Please wrap <YOUR_THIRDWEB_CLIENT_ID> in quotes:

'x-client-id': '<YOUR_THIRDWEB_CLIENT_ID>'

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.27%. Comparing base (a9dd26c) to head (3f56252).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5681   +/-   ##
=======================================
  Coverage   51.27%   51.27%           
=======================================
  Files        1092     1092           
  Lines       57346    57346           
  Branches     4685     4685           
=======================================
  Hits        29404    29404           
  Misses      27226    27226           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a9dd26c
packages 47.90% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (-0.03% 🔽) 899 ms (-0.03% 🔽) 280 ms (+41.61% 🔺) 1.2 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 597 ms (-17.95% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 73 ms (+425.98% 🔺) 184 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 18 ms (+175.93% 🔺) 28 ms
thirdweb/react (minimal + tree-shaking) 19.01 KB (0%) 381 ms (0%) 130 ms (+398.59% 🔺) 510 ms

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 11, 2024

Merge activity

## Problem solved

https://linear.app/thirdweb/issue/INSIGHT-480/improvements-required-for-insight-playground

Updated the authentication method in the Insight API documentation to use the `x-client-id` header instead of embedding the client ID in the URL path.

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the GitHub workflow and documentation related to the `insight` feature. It enhances the valid issue prefixes and provides clearer instructions for authentication in the API usage.

### Detailed summary
- Updated `VALID_ISSUE_PREFIXES` to include `INSIGHT`.
- Improved documentation in `apps/portal/src/app/insight/get-started/page.mdx`:
  - Corrected "clientId" to "client ID".
  - Added a note about using the `x-client-id` header for authentication.
- Modified the API fetch request to include headers for `client ID`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants