Skip to content

Conversation

@jakubkrehel
Copy link
Contributor

@jakubkrehel jakubkrehel commented Dec 10, 2024

Fixes: DASH-580


PR-Codex overview

This PR focuses on updating the UI components in the nebula-waitlist-page-ui.client.tsx and TeamProjectsPage.tsx files. It enhances the layout, spacing, and styling for better visual consistency and user experience.

Detailed summary

  • Increased gap in nebula-waitlist-page-ui.client.tsx from gap-3 to gap-6.
  • Changed paragraph width and size in nebula-waitlist-page-ui.client.tsx.
  • Reduced height of a div from h-10 to h-6 in nebula-waitlist-page-ui.client.tsx.
  • Increased padding in TeamProjectsPage.tsx from p-4 to p-5.
  • Restructured project card layout in TeamProjectsPage.tsx for better alignment.
  • Changed CopyButton hover background color from bg-background to bg-secondary in TeamProjectsPage.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 10, 2024

@changeset-bot
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 4831926

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 7:20pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 11, 2024 7:20pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 11, 2024 7:20pm
wallet-ui ⬜️ Skipped (Inspect) Dec 11, 2024 7:20pm

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 10, 2024
@codecov
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.52%. Comparing base (2fccfc0) to head (4831926).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5686   +/-   ##
=======================================
  Coverage   51.52%   51.52%           
=======================================
  Files        1093     1093           
  Lines       57588    57588           
  Branches     4755     4755           
=======================================
  Hits        29671    29671           
  Misses      27200    27200           
  Partials      717      717           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 2fccfc0
packages 48.22% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 3.3 s (+91.94% 🔺) 4.2 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 7.7 s (+42.97% 🔺) 10 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 200 ms (-7.29% 🔽) 311 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 135 ms (-70.11% 🔽) 145 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 819 ms (+22.87% 🔺) 1.2 s

Copy link
Member

jnsdls commented Dec 10, 2024

Merge activity

  • Dec 10, 6:21 PM EST: Graphite disabled "merge when ready" on this PR due to: a merge conflict with the target branch; resolve the conflict and try again..
  • Dec 11, 2:16 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 11, 2:21 PM EST: A user merged this pull request with the Graphite merge queue.

Fixes: DASH-580

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on improving the UI layout and styling of the `nebula-waitlist-page-ui.client.tsx` and `TeamProjectsPage.tsx` components within the dashboard application. It enhances spacing and text presentation for a better user experience.

### Detailed summary
- Increased gap in `nebula-waitlist-page-ui.client.tsx` from `gap-3` to `gap-6`.
- Adjusted paragraph width in `nebula-waitlist-page-ui.client.tsx` for better text alignment.
- Reduced height of a div from `h-10` to `h-6` in `nebula-waitlist-page-ui.client.tsx`.
- Increased padding in project card from `p-4` to `p-5` in `TeamProjectsPage.tsx`.
- Changed the class of `CopyButton` from `hover:bg-background` to `hover:bg-secondary` in `TeamProjectsPage.tsx`.
- Adjusted text presentation and layout for project details in `TeamProjectsPage.tsx`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the jakub/dash-580-project-card-design-fix-nebula-fix branch from 720f6c9 to 4831926 Compare December 11, 2024 19:17
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 11, 2024 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 11, 2024 19:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 11, 2024 19:17 Inactive
@graphite-app graphite-app bot merged commit 4831926 into main Dec 11, 2024
31 checks passed
@graphite-app graphite-app bot deleted the jakub/dash-580-project-card-design-fix-nebula-fix branch December 11, 2024 19:21
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 11, 2024 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 11, 2024 19:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 11, 2024 19:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants