Skip to content

Conversation

@joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 11, 2024

Problem solved

CNCT-2590


PR-Codex overview

This PR focuses on enhancing wallet connection features by improving the handling of connected wallets, adding auto-connect functionality, and optimizing profile linking processes.

Detailed summary

  • Updated StyledConnectButton to accept props.
  • Changed useAddConnectedWallet to return manager.addConnectedWallet.
  • Refined wallet filtering logic in useAutoConnect.
  • Modified storage of connected wallet IDs to avoid duplicates.
  • Introduced delays in LinkProfileScreen for query invalidation.
  • Switched from useAdminWallet to useConnectedWallets in multiple hooks.
  • Improved ecosystem wallet handling in profile queries and mutations.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: dbbeb9d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
thirdweb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:34am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:34am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:34am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:34am

@joaquim-verges joaquim-verges marked this pull request as ready for review December 11, 2024 02:38
@github-actions github-actions bot added Playground Changes involving the Playground codebase. packages SDK Involves changes to the thirdweb SDK labels Dec 11, 2024
Copy link
Member Author

joaquim-verges commented Dec 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.93 KB (0%) 899 ms (0%) 3.2 s (+3.78% 🔺) 4.1 s
thirdweb (cjs) 110.71 KB (0%) 2.3 s (0%) 5.8 s (+13.54% 🔺) 8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 417 ms (+206.07% 🔺) 529 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 78 ms (-30.55% 🔽) 88 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (+0.32% 🔺) 382 ms (+0.32% 🔺) 424 ms (-27.64% 🔽) 805 ms

@codecov
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 24 lines in your changes missing coverage. Please review.

Project coverage is 51.26%. Comparing base (a9dd26c) to head (dbbeb9d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...hirdweb/src/react/web/hooks/wallets/useProfiles.ts 0.00% 16 Missing ⚠️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 0.00% 6 Missing ⚠️
.../react/core/hooks/wallets/useAddConnectedWallet.ts 0.00% 1 Missing ⚠️
packages/thirdweb/src/wallets/manager/index.ts 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5688      +/-   ##
==========================================
- Coverage   51.27%   51.26%   -0.01%     
==========================================
  Files        1092     1092              
  Lines       57346    57375      +29     
  Branches     4685     4691       +6     
==========================================
+ Hits        29404    29416      +12     
- Misses      27226    27243      +17     
  Partials      716      716              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a9dd26c
packages 47.89% <20.00%> (-0.01%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...web/src/react/core/hooks/wallets/useAutoConnect.ts 41.22% <100.00%> (ø)
.../react/core/hooks/wallets/useAddConnectedWallet.ts 40.00% <0.00%> (ø)
packages/thirdweb/src/wallets/manager/index.ts 85.34% <83.33%> (+0.96%) ⬆️
...web/ui/ConnectWallet/screens/LinkProfileScreen.tsx 5.61% <0.00%> (-0.27%) ⬇️
...hirdweb/src/react/web/hooks/wallets/useProfiles.ts 7.14% <0.00%> (-3.39%) ⬇️

... and 7 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit da5d8ec into main Dec 11, 2024
31 of 32 checks passed
@joaquim-verges joaquim-verges deleted the fix_Autoconnect_previously_linked_wallets branch December 11, 2024 06:58
@jnsdls jnsdls mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Playground Changes involving the Playground codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants