Skip to content

Conversation

@kien-ngo
Copy link
Contributor

@kien-ngo kien-ngo commented Dec 11, 2024

CNCT-2620


PR-Codex overview

This PR introduces headless components for wallet integration in the thirdweb library, specifically WalletProvider, WalletIcon, and WalletName, enhancing the wallet context management and UI component structure.

Detailed summary

  • Added headless components: WalletProvider, WalletIcon, WalletName.
  • Updated ChainProvider to mark it as @beta.
  • Exported new wallet components in react.ts.
  • Added documentation for wallet components in page.mdx.
  • Implemented getQueryKeys functions for wallet and chain name retrieval.
  • Enhanced tests for WalletName, WalletIcon, and WalletProvider functionalities.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 10:35am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 10:35am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 10:35am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2024 10:35am

@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 33ab8c7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Minor
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 11, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added Portal Involves changes to the Portal (docs) codebase. packages labels Dec 11, 2024
@github-actions github-actions bot added the SDK Involves changes to the thirdweb SDK label Dec 11, 2024
@kien-ngo kien-ngo changed the title update [SDK] Headless Wallet components Dec 11, 2024
Copy link
Contributor Author

kien-ngo commented Dec 11, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@kien-ngo kien-ngo changed the title [SDK] Headless Wallet components [SDK] Headless Wallet components | CNCT- Dec 11, 2024
@kien-ngo kien-ngo changed the title [SDK] Headless Wallet components | CNCT- [SDK] Headless Wallet components | CNCT-2620 Dec 11, 2024
@linear
Copy link

linear bot commented Dec 11, 2024

@kien-ngo kien-ngo marked this pull request as ready for review December 11, 2024 09:42
@kien-ngo kien-ngo requested a review from a team as a code owner December 11, 2024 09:42
@kien-ngo kien-ngo requested a review from a team December 11, 2024 09:42
@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 3.1 s (+39.37% 🔺) 4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 6.8 s (+52.07% 🔺) 9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 428 ms (+89.43% 🔺) 540 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 68 ms (-62.87% 🔽) 78 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 877 ms (+56.7% 🔺) 1.3 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 14, 2024

Merge activity

joaquim-verges pushed a commit that referenced this pull request Dec 14, 2024
CNCT-2620

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces headless components for managing wallet interactions in the `thirdweb` library, including `WalletProvider`, `WalletIcon`, and `WalletName`. It enhances wallet context management and adds functionality for fetching wallet information.

### Detailed summary
- Added `WalletProvider`, `WalletIcon`, and `WalletName` components.
- Exported new wallet-related components and types from `react.ts`.
- Updated documentation for wallet components in `page.mdx`.
- Implemented context and hooks for wallet management.
- Enhanced `ChainName` component and added query key functions.
- Added tests for new wallet components and functionality.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@joaquim-verges joaquim-verges force-pushed the kien/headless-ui-wallet-component branch from 90e9d68 to 33ab8c7 Compare December 14, 2024 10:11
@kien-ngo kien-ngo force-pushed the kien/headless-ui-wallet-component branch from 33ab8c7 to 2de56d9 Compare December 14, 2024 10:11
CNCT-2620

<!-- start pr-codex -->

---

## PR-Codex overview
This PR introduces new headless components for wallet management in the `thirdweb` library, enhancing user interface options for wallet context, icons, and names.

### Detailed summary
- Added `WalletProvider`, `WalletIcon`, and `WalletName` components.
- Updated `ChainProvider` to mark it as `@beta`.
- Introduced utility functions `getQueryKeys` for both chain and wallet components.
- Updated documentation and tests for new wallet components.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages Portal Involves changes to the Portal (docs) codebase. SDK Involves changes to the thirdweb SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants