Custom create2 factory deployment for skale chains #5693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaryash90
requested review from
gregfromstl,
jnsdls and
joaquim-verges
as code owners
🦋 Changeset detectedLatest commit: 7c40fda The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5693 +/- ##
==========================================
+ Coverage 53.20% 53.34% +0.13%
==========================================
Files 1101 1101
Lines 59100 59124 +24
Branches 4817 4825 +8
==========================================
+ Hits 31447 31541 +94
+ Misses 26936 26864 -72
- Partials 717 719 +2
*This pull request uses carry forward flags. Click here to find out more.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/thirdweb/src/contract/deployment/utils/create-2-factory.ts
Outdated
Show resolved
Hide resolved
joaquim-verges
approved these changes
Dec 13, 2024
TOOL-2779 (XPROT-931)
## Problem solved
Short description of the bug fixed or feature added
<!-- start pr-codex -->
---
## PR-Codex overview
This PR introduces a custom `create2` factory deployment for SKALE chains, enhancing gas management and testing functionalities.
### Detailed summary
- Added tests for `create2` factory address computation and deployment in `create-2-factory.test.ts`.
- Introduced `Create2FactoryDeploymentInfo` type in `create-2-factory.ts`.
- Implemented custom gas price and limit handling for specific SKALE chains.
- Updated `deployCreate2Factory` to utilize custom gas settings.
> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`
<!-- end pr-codex -->
kumaryash90
force-pushed
the
yash/skale-custom-gas
branch
from
3a1eb19 to
7c40fda
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TOOL-2779 (XPROT-931)
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a custom
create2factory deployment for SKALE chains, enhancing gas management and testing functionalities.Detailed summary
create2factory address computation and deployment.Create2FactoryDeploymentInfotype for deployment details.deployCreate2Factoryto accommodate custom gas settings.