Update /use and types to v2 #5708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3ec808d The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5708 +/- ##
=======================================
Coverage 51.65% 51.65%
=======================================
Files 1097 1097
Lines 57788 57788
Branches 4773 4773
=======================================
Hits 29853 29853
Misses 27217 27217
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
Contributor
size-limit report 📦
|
jnsdls
approved these changes
Dec 12, 2024
| serviceApiKey: string; | ||
| serviceAction?: string; | ||
| useWalletAuth?: boolean; | ||
| includeUsage?: boolean; |
Member
There was a problem hiding this comment.
no longer needed / does nothing?
Contributor
Merge activity
|
## Problem solved CNCT-2640 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on refactoring the `service-utils` package to remove the `usageLimit` module, update types and endpoints to version 2, and enhance authorization logic by integrating team and project responses. ### Detailed summary - Deleted `usageLimit` module files. - Updated API endpoint and types to version 2. - Modified `authorizeClient` and `authorizeService` functions to use `TeamAndProjectResponse`. - Adjusted authorization tests to reflect new structure. - Revised caching logic for keys. - Enhanced rate limiting to use project IDs instead of account IDs. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
jnsdls
force-pushed
the
12-12-update__use_and_types_to_v2
branch
from
23e1938 to
3ec808d
Compare
Merged
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
CNCT-2640
PR-Codex overview
This PR focuses on refactoring the
service-utilspackage to remove theusageLimitmodule and update the authorization logic to incorporate team and project responses, enhancing the overall structure and functionality of the service.Detailed summary
usageLimitrelated files and references.TeamAndProjectResponse.authorizeClientandauthorizeServicefunctions to accept new response types.