[SDK] Feature: Adds defaultCountryCode prop to ConnectButton
#5709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
MananTank,
edwardysun,
jnsdls and
joaquim-verges
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: d955c72 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5709 +/- ##
==========================================
+ Coverage 51.53% 52.88% +1.34%
==========================================
Files 1094 1098 +4
Lines 57592 58976 +1384
Branches 4755 4791 +36
==========================================
+ Hits 29681 31189 +1508
+ Misses 27193 27070 -123
+ Partials 718 717 -1
*This pull request uses carry forward flags. Click here to find out more.
|
gregfromstl
force-pushed
the
greg/cnct-2585-add-config-to-change-default-country-code
branch
from
3de0ec8 to
0bd48d7
Compare
.changeset/fast-items-film.md
Outdated
| ], | ||
| mode: "redirect", | ||
| passkeyDomain: getDomain(), | ||
| defaultSmsCountryCode: "AF", |
Member
There was a problem hiding this comment.
i would just show this option, maybe with auth option "phone"
kinda confusing to see passkey/mode in here too
.changeset/fast-items-film.md
Outdated
Comment on lines
10
to
22
| options: [ | ||
| "google", | ||
| "discord", | ||
| "telegram", | ||
| "email", | ||
| "passkey", | ||
| "phone", | ||
| "farcaster", | ||
| "line", | ||
| ], | ||
| mode: "redirect", | ||
| passkeyDomain: getDomain(), | ||
| defaultSmsCountryCode: "AF", |
Member
There was a problem hiding this comment.
Suggested change
| options: [ | |
| "google", | |
| "discord", | |
| "telegram", | |
| "email", | |
| "passkey", | |
| "phone", | |
| "farcaster", | |
| "line", | |
| ], | |
| mode: "redirect", | |
| passkeyDomain: getDomain(), | |
| defaultSmsCountryCode: "AF", | |
| options: [ | |
| "phone", | |
| ], | |
| defaultSmsCountryCode: "IN", // default to india country code |
gregfromstl
deleted the
greg/cnct-2585-add-config-to-change-default-country-code
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces a
defaultSmsCountryCodeconfiguration option for In-App and Ecosystem Wallets, enhancing SMS authentication by allowing a default country code to be set.Detailed summary
defaultSmsCountryCodeoption tocreateWalletfor In-App and Ecosystem Wallets.EcosystemWalletCreationOptionsandInAppWalletCreationOptionsto includedefaultSmsCountryCode.InputSelectionUIto initializecountryCodeInfowithdefaultSmsCountryCode.InputSelectionUIandCountrySelectorto verify default country code behavior.