Skip to content

[Nebula] Remove presence message when adding an error message #5711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 12, 2024
Merged

[Nebula] Remove presence message when adding an error message #5711

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions apps/dashboard/src/app/nebula-app/(app)/components/ChatPageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,21 @@ export function ChatPageContent(props: {
return;
}
console.error(error);
setMessages((prev) => [
...prev,
{

setMessages((prev) => {
const newMessages = prev.slice(
0,
prev[prev.length - 1]?.type === "presence" ? -1 : undefined,
);

// add error message
newMessages.push({
text: `Error: ${error instanceof Error ? error.message : "Failed to execute command"}`,
type: "error",
},
]);
});

return newMessages;
Comment on lines +252 to +258
Copy link
Member

@jnsdls jnsdls Dec 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still would prefer to not mutate the array with push and instead do [...newMessages, {}] but it's a nitpick at this point so ship it

});
} finally {
setIsChatStreaming(false);
}
Expand Down
Loading