Skip to content

Conversation

@jnsdls
Copy link
Member

@jnsdls jnsdls commented Dec 13, 2024

fixes: DASH-621

we explicitly DO NOT want to derive from secretKey anymore - this would otherwise block multi secret key per project


PR-Codex overview

This PR focuses on removing unused functionality and simplifying the code related to client ID derivation and authorization in the Node service, enhancing clarity and maintainability.

Detailed summary

  • Removed includeUsage property from the TeamAndProjectResponse type.
  • Deleted the deriveClientIdFromSecretKeyHash function.
  • Eliminated client ID validation logic in authorizeNode and extractAuthorizationData functions.
  • Removed extensive comments documenting the parameters of the authorizeNode function.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 6:22am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 13, 2024 6:22am
thirdweb_playground ⬜️ Skipped (Inspect) Dec 13, 2024 6:22am
wallet-ui ⬜️ Skipped (Inspect) Dec 13, 2024 6:22am

Copy link
Member Author

jnsdls commented Dec 13, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls marked this pull request as ready for review December 13, 2024 06:04
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 67f63c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@linear
Copy link

linear bot commented Dec 13, 2024

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.85%. Comparing base (a077023) to head (67f63c3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5729   +/-   ##
=======================================
  Coverage   52.85%   52.85%           
=======================================
  Files        1098     1098           
  Lines       58976    58976           
  Branches     4788     4788           
=======================================
  Hits        31173    31173           
  Misses      27087    27087           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from a077023
packages 49.95% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 470 ms (+0.02% 🔺) 1.4 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 1.1 s (+27.47% 🔺) 3.4 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 178 ms (+469.41% 🔺) 289 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 40 ms (+534.33% 🔺) 50 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 211 ms (+314.91% 🔺) 592 ms

@jnsdls jnsdls changed the base branch from 12-12-allow_passing_null_to_service_scope_do_not_check_domains_on_secretkey_auth to graphite-base/5729 December 13, 2024 06:12
@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 13, 2024

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/5729 to main December 13, 2024 06:17
fixes: DASH-621

we explicitly *DO NOT* want to derive from secretKey anymore - this would otherwise block multi secret key per project
@jnsdls jnsdls force-pushed the remove_client_ID_derivation_from_secret_key branch from 0a4254a to 67f63c3 Compare December 13, 2024 06:18
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 06:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 06:18 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 06:18 Inactive
@graphite-app graphite-app bot merged commit 67f63c3 into main Dec 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the remove_client_ID_derivation_from_secret_key branch December 13, 2024 06:23
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 13, 2024 06:23 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants