Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 13, 2024

Problem solved

DASH-615


PR-Codex overview

This PR focuses on enhancing the ContextFilters functionality in the dashboard application by adding support for walletAddresses, refining the session management, and updating related components to accommodate the new filters.

Detailed summary

  • Added walletAddresses to the promptNebula parameters in chat.ts.
  • Updated session.ts to include wallet_addresses in the session context filters.
  • Created a new type SessionContextFilter in types.ts to encapsulate the filter structure.
  • Modified ChatPageContent to manage and utilize walletAddresses.
  • Enhanced ContextFiltersButton to display walletAddresses in the UI.
  • Updated form validation in ContextFilters to include walletAddresses.
  • Added input handling for walletAddresses in the context filter dialog.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 8:11pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 13, 2024 8:11pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 13, 2024 8:11pm
wallet-ui ⬜️ Skipped (Inspect) Dec 13, 2024 8:11pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 19:54 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 19:54 Inactive
@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 9b58a08

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 13, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 13, 2024 19:55
@MananTank MananTank changed the title [Dashboard] Nebula - Update context filters [Dashboard] Nebula - Update context filters + Add OG image Dec 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 391 ms (+20.43% 🔺) 1.3 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 969 ms (+37.77% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 174 ms (+111.82% 🔺) 285 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 41 ms (+697.71% 🔺) 51 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 179 ms (+302.27% 🔺) 559 ms

@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (22bc557) to head (9b58a08).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5736   +/-   ##
=======================================
  Coverage   52.89%   52.89%           
=======================================
  Files        1099     1099           
  Lines       59010    59010           
  Branches     4791     4791           
=======================================
  Hits        31211    31211           
  Misses      27083    27083           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 22bc557
packages 49.99% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 13, 2024

Merge activity

## Problem solved

DASH-615

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on enhancing the context filter functionality within the application by introducing support for `walletAddresses`, updating related types, and modifying components to accommodate these changes.

### Detailed summary
- Added `walletAddresses` to various types and API parameters.
- Updated `SessionContextFilter` to include `wallet_addresses`.
- Modified `ChatPageContent` to handle and display `walletAddresses`.
- Enhanced `ContextFiltersButton` to show wallet address badges.
- Updated form handling to include validation for `walletAddresses`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
@jnsdls jnsdls force-pushed the 12-14-_dashboard_nebula_-_update_context_filters branch from a64233a to 9b58a08 Compare December 13, 2024 20:08
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 20:09 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 20:09 Inactive
@graphite-app graphite-app bot merged commit 9b58a08 into main Dec 13, 2024
32 checks passed
@graphite-app graphite-app bot deleted the 12-14-_dashboard_nebula_-_update_context_filters branch December 13, 2024 20:16
@vercel vercel bot temporarily deployed to Production – wallet-ui December 13, 2024 20:16 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 13, 2024 20:16 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 December 13, 2024 20:16 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants