Skip to content

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Dec 13, 2024

Problem solved

DASH-616


PR-Codex overview

This PR primarily focuses on UI improvements in the NebulaMobileNav and ChatSidebar components. It updates icon sizes and enhances layout and styling for better user experience.

Detailed summary

  • In NebulaMobileNav.tsx, the size of the MenuIcon is increased from size-6 to size-8.
  • In ChatSidebar.tsx:
    • Added Badge component for displaying an "Alpha" label with a FlaskConicalIcon.
    • Updated the layout of the top div to have a gap and align items centrally.
    • Imported FlaskConicalIcon in addition to existing icons.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@linear
Copy link

linear bot commented Dec 13, 2024

DASH-616 Alpha Label

@vercel
Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 9:36pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Dec 13, 2024 9:36pm
thirdweb_playground ⬜️ Skipped (Inspect) Dec 13, 2024 9:36pm
wallet-ui ⬜️ Skipped (Inspect) Dec 13, 2024 9:36pm

@changeset-bot
Copy link

changeset-bot bot commented Dec 13, 2024

⚠️ No Changeset found

Latest commit: 34165cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 21:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 21:23 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Dec 13, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review December 13, 2024 21:23
@codecov
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.89%. Comparing base (9954b37) to head (34165cb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5738   +/-   ##
=======================================
  Coverage   52.89%   52.89%           
=======================================
  Files        1099     1099           
  Lines       59010    59010           
  Branches     4791     4791           
=======================================
  Hits        31211    31211           
  Misses      27083    27083           
  Partials      716      716           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9954b37
packages 49.99% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 3.7 s (+10.26% 🔺) 4.6 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 6.8 s (-4.07% 🔽) 9 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 143 ms (-50.59% 🔽) 254 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 115 ms (+44% 🔺) 125 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 801 ms (+82.21% 🔺) 1.2 s

@graphite-app
Copy link
Contributor

graphite-app bot commented Dec 13, 2024

Merge activity

@jnsdls jnsdls force-pushed the 12-14-_dash-616_nebula_-_add_alpha_badge_in_sidebar branch from 1da40aa to 34165cb Compare December 13, 2024 21:34
@vercel vercel bot temporarily deployed to Preview – docs-v2 December 13, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 13, 2024 21:34 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 13, 2024 21:34 Inactive
@graphite-app graphite-app bot merged commit 34165cb into main Dec 13, 2024
31 checks passed
@graphite-app graphite-app bot deleted the 12-14-_dash-616_nebula_-_add_alpha_badge_in_sidebar branch December 13, 2024 21:37
@vercel vercel bot temporarily deployed to Production – docs-v2 December 13, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui December 13, 2024 21:37 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground December 13, 2024 21:37 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants